Skip to content

Note fix for endianness in tests - #441

Merged
jakirkham merged 1 commit into
zarr-developers:masterfrom
jakirkham:changelog_pr_427
May 23, 2019
Merged

jakirkham merged 1 commit into
zarr-developers:masterfrom
jakirkham:changelog_pr_427

Conversation

@jakirkham

@jakirkham jakirkham commented May 22, 2019 •

Copy link
Copy Markdown
Member

Adds a changelog entry for PR ( #427 ).

cc @QuLogic

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • Docs build locally (e.g., run tox -e docs)
  • AppVeyor and Travis CI passes
  • Test coverage is 100% (Coveralls passes)

This was referenced May 22, 2019
@jakirkham

Copy link
Copy Markdown
Member Author

Merging in 24hrs if no comments.

@alimanfoo

Copy link
Copy Markdown
Member

Thanks @jakirkham and @QuLogic.

@QuLogic QuLogic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakirkham

Copy link
Copy Markdown
Member Author

Thanks all. 😄 Merging...

@jakirkham
jakirkham merged commit 7431e47 into zarr-developers:master May 23, 2019
@jakirkham
jakirkham deleted the changelog_pr_427 branch May 23, 2019 14:12
d-v-b added a commit that referenced this pull request Nov 9, 2026
* docs(zarr-metadata): say that to_json returns arrays as tuples

The guide said `to_json` returns plain containers, while another section
said it returns tuples. Each model's `to_json` docstring now says that
every JSON array is a tuple, as the package's JSON types spell one, so
the result does not compare equal to `json.loads` output, and points to
comparing models instead. Prompted by refkv's report.

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <[email protected]>

* docs(zarr-metadata): number the changelog fragment for #441

Assisted-by: ClaudeCode:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <[email protected]>

* docs(zarr-metadata): number the changelog fragment for #4608

Assisted-by: ClaudeCode:claude-opus-5-5

---------

Co-authored-by: Claude Opus 5.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants