Skip to content

deps: add packaging to required deps - #2573

Merged
dstansby merged 3 commits into
zarr-developers:mainfrom
jhamman:dep/packaging
Dec 19, 2024
Merged

dstansby merged 3 commits into
zarr-developers:mainfrom
jhamman:dep/packaging

Conversation

@jhamman

@jhamman jhamman commented Dec 18, 2024 •

Copy link
Copy Markdown
Member

Closes #2487

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@jhamman
jhamman requested a review from dstansby December 18, 2024 16:59
@jhamman

jhamman commented Dec 18, 2024

Copy link
Copy Markdown
Member Author

Any ideas why mypy is failing here?

@dstansby

Copy link
Copy Markdown
Contributor

At a glance and a guess, a change in recently-released numpy 2.2?

@jhamman

jhamman commented Dec 18, 2024

Copy link
Copy Markdown
Member Author

@dstansby - I've pinned numpy in our precommit/mypy config now and reported the regression upstream.

@dstansby
dstansby merged commit 5bf7bcf into zarr-developers:main Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing packaging dependency

2 participants