Skip to content

Detect AVX2 - #20

Merged
alimanfoo merged 1 commit into
masterfrom
cpuinfo
Apr 14, 2016
Merged

alimanfoo merged 1 commit into
masterfrom
cpuinfo

Conversation

@alimanfoo

Copy link
Copy Markdown
Member

This PR modifies setup.py to detect support for AVX2 via the cpuinfo module.

Resolves #4.

cc @FrancescAlted this looks like it works, maybe useful for bcolz and python-blosc too.

@alimanfoo alimanfoo added this to the v0.4 milestone Apr 14, 2016
@FrancescAlted

Copy link
Copy Markdown

Cool. Although provided that you cannot currently pass a better optimization level larger than -O1 in Python extensions, I am -0 in porting this back to bcolz or python-blosc. I think it is much better that people start using the C-Blosc library directly as stated in:

https://github.com/Blosc/python-blosc#compiling-with-an-installed-blosc-library-recommended

@alimanfoo

Copy link
Copy Markdown
Member Author

Fair enough. It is strange but I am not seeing any segfaults with zarr, so
I have not limited the compiler optimisation level in setup.py. I haven't
used heavily yet tho so the same issue may still be there.

On Thursday, 14 April 2016, FrancescAlted [email protected] wrote:

Cool. Although provided that you cannot currently pass a better
optimization level larger than -O1 in Python extensions
Blosc/python-blosc#110, I am -0 in porting
this back to bcolz or python-blosc. I think it is much better that people
start using the C-Blosc library directly as stated in:

https://github.com/Blosc/python-blosc#compiling-with-an-installed-blosc-library-recommended

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/alimanfoo/zarr/pull/20#issuecomment-209907133

Alistair Miles
Head of Epidemiological Informatics
Centre for Genomics and Global Health http://cggh.org
The Wellcome Trust Centre for Human Genetics
Roosevelt Drive
Oxford
OX3 7BN
United Kingdom
Email: [email protected] [email protected]
Web: http://purl.org/net/aliman
Twitter: https://twitter.com/alimanfoo
Tel: +44 (0)1865 287721

@alimanfoo
alimanfoo merged commit fe4cd8e into master Apr 14, 2016
@FrancescAlted

Copy link
Copy Markdown

No more segfaults? Hmmm, strange... I think they will come again, but I think it is nice that you enable -O2 or higher in zarr just to keep track of this.

@alimanfoo

Copy link
Copy Markdown
Member Author

FWIW I have never seen segfaults with zarr, only bcolz. The previous
version of zarr only used the blosc contextual functions. The next zarr
release which I'm just preparing will have the option to use either the
contextual functions or the non-contextual functions like bcolz, so
something may come up. I'll try to run some heavier tests and see what
happens.

On Thursday, 14 April 2016, FrancescAlted [email protected] wrote:

No more segfaults? Hmmm, strange... I think they will come again, but I
think it is nice that you enable -O2 or higher in zarr just to keep track
of this.

—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
https://github.com/alimanfoo/zarr/pull/20#issuecomment-210088188

Alistair Miles
Head of Epidemiological Informatics
Centre for Genomics and Global Health http://cggh.org
The Wellcome Trust Centre for Human Genetics
Roosevelt Drive
Oxford
OX3 7BN
United Kingdom
Email: [email protected] [email protected]
Web: http://purl.org/net/aliman
Twitter: https://twitter.com/alimanfoo
Tel: +44 (0)1865 287721

@alimanfoo
alimanfoo deleted the cpuinfo branch August 31, 2016 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants