Repository navigation
change warning to error for non-string key attributes - #1183
Closed
I-am-Emmanuel wants to merge 2 commits into
Closed
I-am-Emmanuel wants to merge 2 commits into
I-am-Emmanuel wants to merge 2 commits into
Conversation
|
This pull request introduces 2 alerts when merging bd031a5 into eb6d143 - view on LGTM.com new alerts:
|
Member
|
Sorry, @I-am-Emmanuel. You're PR is technically correct (though I would remove the commented out sections) but it is a breaking change. That's the reason I created the issue: to remind us when the time comes. I've updated the description to prevent future confusion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Description of PR]
TODO: