Specification for datetime dtypes is ambiguous #85

Activity

1. alimanfoo commented on Oct 17, 2016

   

   alimanfoo

   on Oct 17, 2016

   Member

   More actions

   Thanks @shoyer, I have no experience of using either dtype so very happy to defer to your judgement here.
2. alimanfoo

   modified the milestone: v2.2 on Dec 15, 2016
3. alimanfoo

   added

   to do

   on Oct 31, 2017
4. alimanfoo commented on Nov 18, 2017

   

   alimanfoo

   on Nov 18, 2017

   Member

   More actions

   Just looking at this, datetime64 is kind-of supported at the moment but it's a mess. There is an issue (https://github.com/alimanfoo/numcodecs/issues/39) that prevents buffer access to a datetime64 array, which can be worked around with a filter, e.g.:

   In [34]: a = np.array(['2007-07-13', '2006-01-13', '2010-08-13'], dtype='datetime64[D]')
   
   In [35]: z = zarr.array(a, fill_value=None, filters=[numcodecs.AsType('i8', a.dtype)])
   
   In [36]: z[:]
   Out[36]: array(['2007-07-13', '2006-01-13', '2010-08-13'], dtype='datetime64[D]')
   

   Also currently requires fill_value=None otherwise get a JSON serialization exception.

   I think I will remove these from the spec for now, and also raise a ValueError if some tries to create an array with datetime or timedelta dtype explaining the situation.
5. alimanfoo

   added

   documentationImprovements to the documentationImprovements to the documentation

   release notes doneAutomatically applied to PRs which have release notes.Automatically applied to PRs which have release notes.

   on Nov 20, 2017
6. alimanfoo

   closed this as completedin #185on Nov 20, 2017
7. alimanfoo

   removed

   to do

   on Nov 20, 2017