Skip to content

avoid comparing exact output of gzip encoding in codec pipeline tests #4254

Closed

Description

@d-v-b

https://github.com/zarr-developers/zarr-python/actions/runs/31607404847/job/94150195454?pr=4253 shows a test failure caused by two gzip-encoded bytestreams differ. from what an llm told me, this is due to gzip including timestamp info in compressed payloads, which makes two gzip streams differ even if they decode to the exact same bytes. so tests for exact byte consistency should be avoided here in favor of round-trip fidelity.

Activity

  1. sheikhayaan commented on Aug 18, 2026

    @sheikhayaan
    Contributor

    "Hi, I'd like to work on this. I'll find the test that compares exact gzip bytes and change it to compare decoded output instead. Does this approach sound right?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions