Repository navigation
What is the abstract ArrayMetadata class for #2300
Description
Can someone explain why we need an abstract base class for array metadata, as opposed to handling the union of the two distinct v2 array metadata and v3 array metadata classes?
I'm asking for academic reasons, because the things we are modelling (zarr metadata documents) are not, in fact, hierarchically related, and we don't anticipate any new metadata documents coming on the scene any time soon. Modelling two similar, but importantly distinct entities as a union seems simpler to me than imposing a common API atop them.
I'm also asking for practical reasons, because I have a forthcoming PR where I have to prune a property off the ArrayMetadata abc to accurately model v2 metadata, and it made me wonder how load bearing that abc really is.
Activity
TomAugspurger commentedon Oct 2, 2024
FWIW, I've wondered the same thing :)
I think that defining
ArrayMetadata = ArrayV2Metadata | ArrayV3Metadatais simpler and lets us write code that's generic over the zarr format equally well.normanrz commentedon Nov 6, 2024
That is what we had initially. @jhamman do you remember why we switched to an abc?
d-v-b commentedon Nov 6, 2024
I think this issue can be closed, since
ArrayMetadatais gone as of #2301