Skip to content

[v3] Accessing data with bools in square bracket notation #1963

Closed

Description

@brokkoli71

Zarr version

v3

Numcodecs version

0.12.1

Python Version

3.12

Operating System

Linux

Description

ix = np.random.binomial(1, 0.6, size=z.shape[0]).astype(bool)
print(z[ix])

will result in IndexError( "unsupported selection item for basic indexing; expected integer or slice, got <class 'numpy.ndarray'>)

while z.get_orthogonal_selection(ix) works.

I suppose the problem is within Array.__getitem__

Steps to reproduce

data = np.arange(10)
z = Array.create(
            StorePath(MemoryStore(mode="w")),
            shape=data.shape,
            chunk_shape=(2,),
            dtype=data.dtype,
            )
z[:] = data
ix = np.random.binomial(1, 0.6, size=z.shape[0]).astype(bool)
print(z.get_orthogonal_selection(ix)) #works
print(z[ix]) #fails

Additional output

No response

Activity

  1. added
    bugPotential issues with the zarr-python library
    on Jun 12, 2024
  2. brokkoli71 commented on Jun 13, 2024

    @brokkoli71
    ContributorAuthor

    Maybe this is expected behavior? as one should always use z.oindex[ix] for orthogonal selection? But then I do not understand why Array.__getitem__ would check for is_pure_orthogonal_indexing

  3. changed the title [-][v3] Accessing data with square bracket notation via orthogonal selection fails[/-] [+][v3] Accessing data with square bracket notation via mask selection fails[/+] on Jun 17, 2024
  4. changed the title [-][v3] Accessing data with square bracket notation via mask selection fails[/-] [+][v3] Accessing data with bools in square bracket notation[/+] on Jun 17, 2024
  5. added this to the 3.0.0 milestone on Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugPotential issues with the zarr-python library

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions