Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: zarr-developers/zarr-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5b5f3a3
Choose a base ref
...
head repository: li-em/zarr-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a97e0f3
Choose a head ref
  • 1 commit
  • 4 files changed
  • 1 contributor

Commits on Sep 1, 2026

  1. fix: orthogonal writes to sharded arrays with index arrays

    The sharding codec derives a second indexer for the selection inside the
    shard. An orthogonal parent selection arrives there in broadcast (np.ix_)
    form. get_indexer then returns a CoordinateIndexer. That indexer
    flattens the selection, and its out selections index a 1-D array. The
    value keeps the broadcast shape. The inner write then raised ValueError.
    Both decode paths already undo this flattening through sel_shape. The
    encode paths now do the same through _value_for_indexer.
    
    CoordinateIndexer also grouped its points by chunk with an unstable
    sort. A repeated index could then take the value of the wrong
    occurrence. The sort is now stable. numpy radix-sorts narrow integer
    keys, so the key dtype is narrowed when the chunk count allows it. That
    measures 3.4 ms against the previous 37 ms for 1e6 points.
    
    Fixing only the first defect turns the exception into silently wrong
    values. So both belong in one change.
    li-em committed Sep 1, 2026
    Configuration menu
    Copy the full SHA
    a97e0f3 View commit details
    Browse the repository at this point in the history
Loading