Repository navigation
Commit f3d406f
authored
fix(zarr-metadata): accept the generic time unit in v2 time dtypes (#4614)
* fix(zarr-metadata): accept the generic time unit in v2 time dtypes
NUMPY_TIME_UNITS gains "generic", NumPy's unit-less unit, which NumPy
parses in brackets (<M8[generic]) though its own dtype.str omits it, so
the v2 reader accepts the bracketed generic spellings zarr-python
writes (<M8[generic], <m8[2generic]). The v3 unit tuple already carried
generic and now reuses the shared tuple unchanged. A unit is still
required: the unitless <M8 stays refused, as the v2 spec demands.
Refs #4580
Assisted-by: ClaudeCode:claude-fable-5
* docs(zarr-metadata): changelog fragment for #422
Assisted-by: ClaudeCode:claude-fable-5
* docs(zarr-metadata): number the generic time unit fragment after its PR
Assisted-by: ClaudeCode:claude-opus-5-51 parent f28c0ad commit f3d406f
4 files changed
Lines changed: 6 additions & 2 deletions
File tree
- packages/zarr-metadata
- changes
- src/zarr_metadata
- v3/data_type
- tests/v2
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
27 | 28 | | |
28 | | - | |
| 29 | + | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| 64 | + | |
64 | 65 | | |
| 66 | + | |
65 | 67 | | |
66 | 68 | | |
67 | 69 | | |
| |||
0 commit comments