Skip to content

Adds a no cover line for the ncores fallback - #96

Merged
jakirkham merged 1 commit into
zarr-developers:masterfrom
jakirkham:no_cover_ncores_fallback
Nov 6, 2018
Merged

jakirkham merged 1 commit into
zarr-developers:masterfrom
jakirkham:no_cover_ncores_fallback

Conversation

@jakirkham

Copy link
Copy Markdown
Member

Follow-up to PR ( #93 )

Adds a no cover for the exception case since cpu_count always works for us on CI.

TODO:

  • Unit tests and/or doctests in docstrings
  • tox -e py37 passes locally
  • tox -e py27 passes locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • tox -e docs passes locally
  • AppVeyor and Travis CI passes
  • Test coverage to 100% (Coveralls passes)

@jakirkham jakirkham mentioned this pull request Nov 6, 2018
@jakirkham
jakirkham requested a review from alimanfoo November 6, 2018 17:44
@jakirkham jakirkham mentioned this pull request Nov 6, 2018
8 tasks
@jakirkham
jakirkham merged commit 6e3e100 into zarr-developers:master Nov 6, 2018
@jakirkham
jakirkham deleted the no_cover_ncores_fallback branch November 6, 2018 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants