Repository navigation
Handle environments where locks are not available - #83
Merged
alimanfoo merged 3 commits intoNov 6, 2018
Merged
Conversation
Member
|
Thanks Marcus, just back from holidays, will take a look asap.
…On Thursday, 23 August 2018, Marcus Kinsella ***@***.***> wrote:
Blosc want to acquire a lock, but locks aren't available in all
environments. In particular, AWS Lambda lacks /dev/shm, so trying to use
blosc will raise an OSError:
>>> import numcodecs.bloscOSError: [Errno 38] Function not implemented
This changes handles missing locks more gracefully by just turning of
threads.
------------------------------
You can view, comment on, or merge this pull request online at:
#83
Commit Summary
- Handle environments where locks are not available
File Changes
- *M* numcodecs/blosc.pyx
<https://github.com/zarr-developers/numcodecs/pull/83/files#diff-0>
(10)
Patch Links:
- https://github.com/zarr-developers/numcodecs/pull/83.patch
- https://github.com/zarr-developers/numcodecs/pull/83.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#83>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAq8QkJ2aLElSIeWCSuTbhmh8PBUQvndks5uTvlMgaJpZM4WKFnl>
.
--
If I do not respond to an email within a few days, please feel free to
resend your email and/or contact me by other means.
Alistair Miles
Head of Epidemiological Informatics
Centre for Genomics and Global Health
Big Data Institute
Li Ka Shing Centre for Health Information and Discovery
Old Road Campus
Headington
Oxford
OX3 7LF
United Kingdom
Phone: +44 (0)1865 743596 or +44 (0)7866 541624
Email: [email protected]
Web: http://a <http://purl.org/net/aliman>limanfoo.github.io/
Twitter: @alimanfoo <https://twitter.com/alimanfoo>
|
Member
|
I hit the same problem on AWS Lambda, and needed to handle another case in numcodecs |
Member
|
Thanks @tomwhite for the feedback. This should be prioritised for the next release. |
Member
|
@alimanfoo that would be great. Thanks. |
alimanfoo
approved these changes
Nov 6, 2018
alimanfoo
left a comment
alimanfoo
left a comment
Member
There was a problem hiding this comment.
Looks good, sorry for delay in reviewing.
Member
|
Thanks @mckinsel. |
Merged
Member
|
@alimanfoo thanks for merging this. Would you be able to take a look at the related change in #93 too please, as I needed that change to successfully run on AWS Lambda. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blosc want to acquire a lock, but locks aren't available in all environments. In particular, AWS Lambda lacks
/dev/shm, so trying to use blosc will raise anOSError:This changes handles missing locks more gracefully by just turning of threads.