Repository navigation
Move tests out of installable distribution - #829
Conversation
|
this is great, thank you! |
|
One note as a downstream packager: since they aren't in the package directory, it's totally fine if the tests are gone from the wheels now, but please if possible ensure that they stay in the sdist. |
how are the tests consumed downstream? |
thanks for keeping a watch on things! I manually verified that the sdist still includes the tests via |
|
FYI the failures are the same as on main, so I will merge despite not having 100% checks |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #829 +/- ##
=======================================
Coverage 99.33% 99.33%
=======================================
Files 26 26
Lines 898 898
=======================================
Hits 892 892
Misses 6 6 🚀 New features to boost your workflow:
|
We run all tests that are possible; that's how I find arch-specific or release candidate bugs.
Thanks for checking! Sorry I didn't have time to do so before. |
Restructure the Unreleased section into a 0.17.0 release section with Breaking changes / Deprecations / Maintenance headings. - Add missing entries for the Python 3.12 / NumPy 2.0 minimums (zarr-developers#834) and the pcodec 1.x update (zarr-developers#817), neither of which was documented. - Move the tests relocation (zarr-developers#829) and the removal of DISABLE_NUMCODECS_CEXT (zarr-developers#826) from Maintenance to Breaking changes, and note that tests are still shipped in the sdist. - Document the delta_spec="none" -> "no_op" deprecation (zarr-developers#817). - Fix leftover RST roles (:user:/:issue:) from the Markdown conversion, which do not render under MyST, and convert RST literal blocks to fenced code. - Add entries for the remaining maintenance PRs since v0.16.5. Assisted-by: ClaudeCode:claude-opus-5 Co-Authored-By: Claude Opus 5 <[email protected]>
Restructure the Unreleased section into a 0.17.0 release section with Breaking changes / Deprecations / Maintenance headings. - Add missing entries for the Python 3.12 / NumPy 2.0 minimums (#834) and the pcodec 1.x update (#817), neither of which was documented. - Move the tests relocation (#829) and the removal of DISABLE_NUMCODECS_CEXT (#826) from Maintenance to Breaking changes, and note that tests are still shipped in the sdist. - Document the delta_spec="none" -> "no_op" deprecation (#817). - Fix leftover RST roles (:user:/:issue:) from the Markdown conversion, which do not render under MyST, and convert RST literal blocks to fenced code. - Add entries for the remaining maintenance PRs since v0.16.5. Assisted-by: ClaudeCode:claude-opus-5 Co-authored-by: Claude Opus 5 <[email protected]>
This PR moves the tests outside the source code directory, so that they are not included with the distributions. This was originally included as part of #826, but is really a distinct change which belongs as its own PR.
Closes #509
TODO: