Repository navigation
update pcodec - #817
update pcodec#817
Conversation
Signed-off-by: mwlon <[email protected]>
Signed-off-by: mwlon <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #817 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 901 905 +4
=========================================
+ Hits 901 905 +4
🚀 New features to boost your workflow:
|
Signed-off-by: mwlon <[email protected]>
Signed-off-by: mwlon <[email protected]>
Signed-off-by: mwlon <[email protected]>
Signed-off-by: mwlon <[email protected]>
|
CI appears to be failing for unrelated reasons. |
|
I understand pcodec now supports Python 3.14. Could you address this comment? numcodecs/.github/workflows/ci.yaml Lines 52 to 57 in 1fdde70 Also, please rebase to resolve conflicts and hopefully fix CI failures. |
Signed-off-by: mwlon <[email protected]>
|
@DimitriPapadopoulos keen eye, updated ci.yaml. |
|
@DimitriPapadopoulos want to review this? |
There was a problem hiding this comment.
I assume the update (and hence the suggested deprcation warning) should be part of the next minor release, not a patch release.
As far as I can see, pcodec does not require specific, recent versions of Python. Therefore, I am confident it supports requires-python = ">=3.12".
I haven't found the time to understand the details of the new fixture yet. Can you perhaps explain why there's no fixture/pcodec/array.10.npy file and what the filtered warning caused by "old fixture files" is about? Is it not possible to update the fixture files?
Signed-off-by: mwlon <[email protected]>
Signed-off-by: mwlon <[email protected]>
|
@DimitriPapadopoulos To answer your questions:
Should be ready for review again, except CI is again failing for unrelated reasons on Linux. |
|
@mwlon Could you rebase? It should fix the CI errors. |
|
@DimitriPapadopoulos looks like @d-v-b merged main into this for us. Can we merge into main now? |
|
Hi! The error should be unrelated; it came from pytest-dev/pytest#14591 via pytest-9.1.0. That is already resolved and fixed in pytest-9.1.1 (edit: sorry, looks like 9.1.1 is not out just yet, but is coming). |
|
thanks all! sorry for the delay. this will be in the next release of numcodecs. |
Restructure the Unreleased section into a 0.17.0 release section with Breaking changes / Deprecations / Maintenance headings. - Add missing entries for the Python 3.12 / NumPy 2.0 minimums (zarr-developers#834) and the pcodec 1.x update (zarr-developers#817), neither of which was documented. - Move the tests relocation (zarr-developers#829) and the removal of DISABLE_NUMCODECS_CEXT (zarr-developers#826) from Maintenance to Breaking changes, and note that tests are still shipped in the sdist. - Document the delta_spec="none" -> "no_op" deprecation (zarr-developers#817). - Fix leftover RST roles (:user:/:issue:) from the Markdown conversion, which do not render under MyST, and convert RST literal blocks to fenced code. - Add entries for the remaining maintenance PRs since v0.16.5. Assisted-by: ClaudeCode:claude-opus-5 Co-Authored-By: Claude Opus 5 <[email protected]>
Restructure the Unreleased section into a 0.17.0 release section with Breaking changes / Deprecations / Maintenance headings. - Add missing entries for the Python 3.12 / NumPy 2.0 minimums (#834) and the pcodec 1.x update (#817), neither of which was documented. - Move the tests relocation (#829) and the removal of DISABLE_NUMCODECS_CEXT (#826) from Maintenance to Breaking changes, and note that tests are still shipped in the sdist. - Document the delta_spec="none" -> "no_op" deprecation (#817). - Fix leftover RST roles (:user:/:issue:) from the Markdown conversion, which do not render under MyST, and convert RST literal blocks to fenced code. - Add entries for the remaining maintenance PRs since v0.16.5. Assisted-by: ClaudeCode:claude-opus-5 Co-authored-by: Claude Opus 5 <[email protected]>
Fixes #815 . Updated to >=v1, which has various improvements.