Skip to content

update pcodec - #817

Merged
d-v-b merged 13 commits into
zarr-developers:mainfrom
mwlon:pcodec-v1
Jun 18, 2026
Merged

d-v-b merged 13 commits into
zarr-developers:mainfrom
mwlon:pcodec-v1

Conversation

@mwlon

@mwlon mwlon commented Feb 12, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #815 . Updated to >=v1, which has various improvements.

Signed-off-by: mwlon <[email protected]>
Signed-off-by: mwlon <[email protected]>
@codecov

codecov Bot commented Feb 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (53e5157) to head (40f1bfc).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #817   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines          901       905    +4     
=========================================
+ Hits           901       905    +4     
Files with missing lines Coverage Δ
src/numcodecs/pcodec.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mwlon

mwlon commented Feb 15, 2026

Copy link
Copy Markdown
Contributor Author

CI appears to be failing for unrelated reasons.

@DimitriPapadopoulos

DimitriPapadopoulos commented Apr 12, 2026 •

Copy link
Copy Markdown
Contributor

I understand pcodec now supports Python 3.14. Could you address this comment?

# TODO: Remove this conditional when pcodec supports Python 3.14
if [[ "${{ matrix.python-version }}" == "3.14" ]]; then
python -m pip install -v ".[test,test_extras,msgpack,google_crc32c,crc32c,zfpy]"
else
python -m pip install -v ".[test,test_extras,msgpack,google_crc32c,crc32c,pcodec,zfpy]"
fi

Also, please rebase to resolve conflicts and hopefully fix CI failures.

@mwlon

mwlon commented Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

@DimitriPapadopoulos keen eye, updated ci.yaml.

@mwlon

mwlon commented Apr 15, 2026

Copy link
Copy Markdown
Contributor Author

@DimitriPapadopoulos want to review this?

@DimitriPapadopoulos DimitriPapadopoulos left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the update (and hence the suggested deprcation warning) should be part of the next minor release, not a patch release.

As far as I can see, pcodec does not require specific, recent versions of Python. Therefore, I am confident it supports requires-python = ">=3.12".

I haven't found the time to understand the details of the new fixture yet. Can you perhaps explain why there's no fixture/pcodec/array.10.npy file and what the filtered warning caused by "old fixture files" is about? Is it not possible to update the fixture files?

Comment thread src/numcodecs/pcodec.py Resolved
Comment thread src/numcodecs/pcodec.py Resolved
mwlon added 2 commits April 18, 2026 08:26
Signed-off-by: mwlon <[email protected]>
@mwlon

mwlon commented Apr 18, 2026

Copy link
Copy Markdown
Contributor Author

@DimitriPapadopoulos To answer your questions:

  • Yes, pcodec supports >= python 3.12 (and <= 3.14 at the moment)
  • There's no new .npy because we didn't add any new arrays - we only added a new codec. The test runs the Cartesian product of arrays x codecs.

Should be ready for review again, except CI is again failing for unrelated reasons on Linux.

@DimitriPapadopoulos

Copy link
Copy Markdown
Contributor

@mwlon Could you rebase? It should fix the CI errors.

@mwlon

mwlon commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

@DimitriPapadopoulos looks like @d-v-b merged main into this for us. Can we merge into main now?

@agriyakhetarpal

agriyakhetarpal commented Jun 18, 2026 •

Copy link
Copy Markdown
Contributor

Hi! The error should be unrelated; it came from pytest-dev/pytest#14591 via pytest-9.1.0. That is already resolved and fixed in pytest-9.1.1 (edit: sorry, looks like 9.1.1 is not out just yet, but is coming).

@d-v-b
d-v-b merged commit f3d6187 into zarr-developers:main Jun 18, 2026
38 checks passed
@d-v-b

d-v-b commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

thanks all! sorry for the delay. this will be in the next release of numcodecs.

d-v-b added a commit to d-v-b/numcodecs that referenced this pull request Sep 17, 2026
Restructure the Unreleased section into a 0.17.0 release section with
Breaking changes / Deprecations / Maintenance headings.

- Add missing entries for the Python 3.12 / NumPy 2.0 minimums (zarr-developers#834) and
  the pcodec 1.x update (zarr-developers#817), neither of which was documented.
- Move the tests relocation (zarr-developers#829) and the removal of DISABLE_NUMCODECS_CEXT
  (zarr-developers#826) from Maintenance to Breaking changes, and note that tests are still
  shipped in the sdist.
- Document the delta_spec="none" -> "no_op" deprecation (zarr-developers#817).
- Fix leftover RST roles (:user:/:issue:) from the Markdown conversion, which
  do not render under MyST, and convert RST literal blocks to fenced code.
- Add entries for the remaining maintenance PRs since v0.16.5.

Assisted-by: ClaudeCode:claude-opus-5

Co-Authored-By: Claude Opus 5 <[email protected]>
d-v-b added a commit that referenced this pull request Sep 17, 2026
Restructure the Unreleased section into a 0.17.0 release section with
Breaking changes / Deprecations / Maintenance headings.

- Add missing entries for the Python 3.12 / NumPy 2.0 minimums (#834) and
  the pcodec 1.x update (#817), neither of which was documented.
- Move the tests relocation (#829) and the removal of DISABLE_NUMCODECS_CEXT
  (#826) from Maintenance to Breaking changes, and note that tests are still
  shipped in the sdist.
- Document the delta_spec="none" -> "no_op" deprecation (#817).
- Fix leftover RST roles (:user:/:issue:) from the Markdown conversion, which
  do not render under MyST, and convert RST literal blocks to fenced code.
- Add entries for the remaining maintenance PRs since v0.16.5.

Assisted-by: ClaudeCode:claude-opus-5

Co-authored-by: Claude Opus 5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade Pcodec to v1

4 participants