Remove deprecated blosc code - #712

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (725cf25) to head (42f9051).
Report is 16 commits behind head on main.

@@            Coverage Diff             @@
##             main     #712      +/-   ##
==========================================
- Coverage   99.96%   99.96%   -0.01%     
==========================================
  Files          63       63              
  Lines        2778     2738      -40     
==========================================
- Hits         2777     2737      -40     
  Misses          1        1              

Hm, this breaks old zarr versions. Is there at least some Zarr 2 version that pins numcodecs to <0.16?

looks like this was a breaking change for some implementations. we might want to revert.

Sorry about this - there's a pin over at zarr-developers/zarr-python#2965, which I'll try and get released ASAP

I'm trying to understand why we didn't revert these changes before issuing a new release, as the changes in this PR are breaking for zarr-python 2.18.

It was my mistake that this broke zarr-python 2.18 - I think the easiest and most pragmatic fix is to put a numcodecs pin in zarr-python 2.18, which I've proposed over at zarr-developers/zarr-python#2965

But given that this PR requires changes to zarr-python, why did we issue a new numcodecs release before the preparatory changes in zarr-python were in?

I guess because we don't proactively test zarr-python v2 against development versions of numcodecs, so this wasn't caught before the release?

I definitely think we should discuss what process/development changes to make so this doesn't happen again, but in the short term it would be great to get a quick review and merge on zarr-developers/zarr-python#2965 so we can unbreak zarr 2.18

maybe i'm getting the timeline wrong, but it looks like the problems with this PR were reported yesterday, but the numcodecs release was today? In theory we could have deferred releasing these changes specifically until zarr-python was prepared for it.

Oh, I made the "release" entry on GitHub this morning, but the actual release/tagging was yesterday.

gotcha, so my timeline was inaccurate

Over at scverse, we use some nice release automation to prevent anything from going wrong with coordinating GitHub/PyPI releases: https://github.com/scverse/anndata/blob/main/.github/workflows/publish.yml

Of course, if you hand-craft the release notes differently for the docs and GitHub, that’s not possible, but if you use the same text, it’s worth it I’d say.