Repository navigation
Conversation
Signed-off-by: odidev <[email protected]>
|
What is needed to include this pull request in the master branch? Aarch64 wheels for Linux are convenient. |
|
Apologies, @odidev. I have no idea how I missed this originally! Never hesitate to re-ping or jump on https://gitter.im/zarr-developers/community -- I'll take a look ASAP. |
joshmoore
left a comment
joshmoore
left a comment
There was a problem hiding this comment.
One small comment. Otherwise, seems like we should give it a try. @jakirkham?
| - name: Build wheel for aarch64 | ||
| if: ${{ matrix.arch == 'aarch64' }} | ||
| env: | ||
| CIBW_ENVIRONMENT: 'DISABLE_NUMCODECS_AVX2=1 DISABLE_NUMCODECS_SSE2=1' |
There was a problem hiding this comment.
Could these have also be set in the setup.py rather than passing? Just wondering if having a single place to look would prevent future issues.
|
Also looking at the conflict, @odidev and @jthetzel, any thoughts on the use of pypa/[email protected] from #309? |
Testing that at #315 . Please advise if not kosher. I get confused on best practices pull requesting against pull requests. |
|
@jthetzel: no worries. Git can take care of all of that. More important is the semantics of the explicit calls to cibuildwheel versus the pre-built action which I'm not familiar enough with to deciper ("without more effort"™️) |
|
Sorry for the lack of reply here. Thought I had already replied. The main concern from my perspective is CI time is getting pretty long for the wheel builds ( #312 ). Would like to limit the builds for custom architectures, libc implementations, etc.. Namely not running on every commit, but only running if a label is added, some text in the commit, particular files changed, etc. Something to keep the build time manageable. |
|
Edit: removed comment once I realized the discussion had moved to #315. |
Add linux aarch64 wheel build support.
Related to #288 @joshmoore Could you please review this PR?