Repository navigation
release wheel for 3.10 #308
Description
Minimal, reproducible code sample, a copy-pastable example if possible
mamba create -n test python=3.10
pip install numcodecs
Problem description
Above code spends some time building the wheel. Which may fail on some systems and also slows down install times. It would be great to bump CI python versions and release the new wheels.
Version and installation information
Please provide the following:
- Value of
numcodecs.__version__0.9.1 - Version of Python interpreter 3.10
- Operating system (Linux/Windows/Mac) linux
- How NumCodecs was installed (e.g., "using pip into virtual environment", or "using conda"): pip
Activity
martindurant commentedon Feb 17, 2022
I think conda-forge has built for 3.10 already, if that will do.
ianhi commentedon Feb 17, 2022
That's a good workaround - but I expect that there will be people who use pip primarily who will also run into this. e.g. i ran into this when doing pip install of different pacakge and it caught me off gaurd. No rush from me to fix, just wanted to bring it up
martindurant commentedon Feb 17, 2022
Sure, we need to update the release too.
jakirkham commentedon Feb 17, 2022
We build wheels with
cibuildwheelin this GH Action. AFAICTcibuildwheelalready supports Python 3.10. So that should just work. Just need to update the version here.Currently CI doesn't cover Python 3.10. So adding that would be good to do.
If someone would like to do a PR to add Python 3.10, that would be a good first step towards addressing this. Not expecting any major issues there, but if they come happy to discuss. @ianhi would you be interested in giving this a try? 🙂
martindurant commentedon Feb 17, 2022
Yes, only if it is up to date
jakirkham commentedon Feb 17, 2022
Good point. Added to the comment above
henryiii commentedon Feb 17, 2022
This is one of the remaining not-on-3.10 yet wheels pyodide pyodide/pyodide#978. Do you still support Python 2? If so, then bumping to cibuildwheel 2.3.1 will drop 2.7 & 3.5 wheels - which is probably a good idea, since the only supported way to make them today is to use manylinux1, which is past EOL and hanging on by a thread. But you can split the job in two and use old cibuildwheel for old Python versions if that's the case. Otherwise, it should be a pretty simple bump.
henryiii commentedon Feb 17, 2022
Excellent, no Python <3.6 support, so should be a simple version bump. If you use our Action, you can even have GitHub Dependabot update this regularly for you.
Minor request, could you please remove the <4 from your Python requires? It causes issues for locking packages managers, and is discouraged. See https://iscinumpy.dev/post/bound-version-constraints/, https://discuss.python.org/t/requires-python-upper-limits, and cjolowicz/cookiecutter-hypermodern-python#1154 for some context / issues related to this.
jakirkham commentedon Feb 17, 2022
What would need to be done to set this up?
jakirkham commentedon Feb 17, 2022
On a side note, would be curious to learn more about how Pyodide & Zarr are being used together. Opened issue ( zarr-developers/community#43 ) for discussion on this 🙂
jakirkham commentedon Feb 19, 2022
We've now added Python 3.10 testing and enabled Python 3.10 wheel builds. All of this thanks to Henry's PR ( #309 ) 😀
Packages are not published yet, but think we are ready to do that next (assuming no other blockers)
jakirkham commentedon Feb 21, 2022
Wheels are now available for testing under
0.10.0a2. Thanks @joshmoore for producing those 😄peterdudfield commentedon Apr 22, 2022
Thanks @jakirkham - worked for me
joshmoore commentedon Apr 23, 2022
Closing but please speak up if there are any remaining issues.
Remove 3.10 testing