Skip to content

feat(init): prefer injector image without imagePullSecrets#4935

Merged
AustinAbro321 merged 14 commits into
mainfrom
allow-users-to-set-injector-image
May 28, 2026
Merged

feat(init): prefer injector image without imagePullSecrets#4935
AustinAbro321 merged 14 commits into
mainfrom
allow-users-to-set-injector-image

Conversation

@AustinAbro321
Copy link
Copy Markdown
Member

@AustinAbro321 AustinAbro321 commented May 27, 2026 •
edited
Loading

Description

This also shifts the logic to prefer images without imagePullSecrets, I assume 99% of the time this should make us land on kube-system.

Related Issue

Relates to #4919

Checklist before merging

@AustinAbro321
allow selected injector image
f5c6799 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321
use coredns image
eb67ea4 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321
add tests
fd18504 
Signed-off-by: Austin Abro <[email protected]>
@AustinAbro321
better test
ba62a6a 
Signed-off-by: Austin Abro <[email protected]>
@netlify
Copy link
Copy Markdown

netlify Bot commented May 27, 2026 •
edited
Loading

✅ Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 904a38b
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/6a184f4d14eb3b00081bd87f
😎 Deploy Preview https://deploy-preview-4935--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@AustinAbro321
make docs and schema
95846fb 
Signed-off-by: Austin Abro <[email protected]>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 50.00000% with 26 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/cluster/injector.go 52.00% 23 Missing and 1 partial ⚠️
src/pkg/packager/deploy.go 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/pkg/packager/deploy.go 3.98% <0.00%> (-0.01%) ⬇️
src/pkg/cluster/injector.go 70.33% <52.00%> (-1.01%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AustinAbro321 AustinAbro321 marked this pull request as ready for review May 27, 2026 16:22
@AustinAbro321 AustinAbro321 requested review from a team as code owners May 27, 2026 16:22
@AustinAbro321 AustinAbro321 changed the title feat(init): allow manually selecting injector image feat(init): prefer injector image without pull creds May 28, 2026
@AustinAbro321 AustinAbro321 changed the title feat(init): prefer injector image without pull creds feat(init): prefer injector image without imagePullSecrets May 28, 2026
soltysh
soltysh reviewed May 28, 2026
View reviewed changes
Comment thread src/pkg/cluster/injector.go Outdated
soltysh
soltysh approved these changes May 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AustinAbro321 AustinAbro321 enabled auto-merge May 28, 2026 14:51
@AustinAbro321 AustinAbro321 added this pull request to the merge queue May 28, 2026
Merged via the queue into main with commit e46fa25 May 28, 2026
38 of 39 checks passed
@AustinAbro321 AustinAbro321 deleted the allow-users-to-set-injector-image branch May 28, 2026 16:04
@github-project-automation github-project-automation Bot moved this to Done in Zarf May 28, 2026
@zarf-release-please zarf-release-please Bot mentioned this pull request May 28, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soltysh soltysh soltysh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Zarf
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AustinAbro321 @soltysh @brandtkeller