Skip to content

feat(values): package inspect values feature support#4867

Merged
brandtkeller merged 11 commits into
mainfrom
4222_inspect_values_support
May 7, 2026
Merged

feat(values): package inspect values feature support#4867
brandtkeller merged 11 commits into
mainfrom
4222_inspect_values_support

Conversation

@brandtkeller
Copy link
Copy Markdown
Member

@brandtkeller brandtkeller commented May 1, 2026

Description

Adds support for zarf package inspect manifests|values-files values templating.

Note: this does not include imports or skeletons as of yet - that will be covered by #4427

This also includes a minor fix for detectign built packages passed to commands that expect a definition path. zarf dev inspect <tarball> gives confusing output.

Related Issue

Fixes #4222

Checklist before merging

@brandtkeller brandtkeller self-assigned this May 1, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 1, 2026

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit ae81fea
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/69fcba7bfcb9840008c41f11

@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

❌ Patch coverage is 26.44628% with 89 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/packager/inspect.go 0.00% 50 Missing and 1 partial ⚠️
src/cmd/dev.go 20.00% 22 Missing and 2 partials ⚠️
src/cmd/package.go 54.16% 8 Missing and 3 partials ⚠️
src/cmd/common.go 57.14% 2 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
src/cmd/cmd.go 81.81% <100.00%> (+13.06%) ⬆️
src/cmd/common.go 57.14% <57.14%> (ø)
src/cmd/package.go 38.25% <54.16%> (+0.13%) ⬆️
src/cmd/dev.go 44.71% <20.00%> (-1.10%) ⬇️
src/pkg/packager/inspect.go 31.08% <0.00%> (-3.68%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brandtkeller brandtkeller marked this pull request as ready for review May 1, 2026 22:48
@brandtkeller brandtkeller requested review from a team as code owners May 1, 2026 22:48
@brandtkeller brandtkeller moved this to PR Review in Zarf May 6, 2026
Copy link
Copy Markdown
Member

@AustinAbro321 AustinAbro321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, minor suggestions

Comment thread src/cmd/cmd.go Outdated
Comment thread src/cmd/package.go Outdated
Comment thread src/pkg/packager/inspect.go
@github-project-automation github-project-automation Bot moved this from PR Review to In progress in Zarf May 7, 2026
@brandtkeller brandtkeller requested a review from AustinAbro321 May 7, 2026 16:15
@brandtkeller brandtkeller added this pull request to the merge queue May 7, 2026
Merged via the queue into main with commit 2a3ef1b May 7, 2026
43 checks passed
@brandtkeller brandtkeller deleted the 4222_inspect_values_support branch May 7, 2026 20:32
@github-project-automation github-project-automation Bot moved this from In progress to Done in Zarf May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add values and templating support for package remove actions and inspect

2 participants