feat(tls): support for tls generation with duration#4769
Merged
Conversation
Signed-off-by: Brandt Keller <[email protected]>
✅ Deploy Preview for zarf-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Signed-off-by: Brandt Keller <[email protected]>
AustinAbro321
requested changes
Apr 6, 2026
Member
AustinAbro321
left a comment
AustinAbro321
left a comment
There was a problem hiding this comment.
Good start, some ideas and thoughts on the first pass through
Signed-off-by: Brandt Keller <[email protected]>
AustinAbro321
requested changes
Apr 9, 2026
Member
AustinAbro321
left a comment
AustinAbro321
left a comment
There was a problem hiding this comment.
UX consideration on re-init
Signed-off-by: Brandt Keller <[email protected]>
Co-authored-by: Austin Abro <[email protected]> Signed-off-by: Brandt Keller <[email protected]>
Signed-off-by: Brandt Keller <[email protected]>
AustinAbro321
requested changes
Apr 13, 2026
Member
AustinAbro321
left a comment
AustinAbro321
left a comment
There was a problem hiding this comment.
One request otherwise lgtm
Co-authored-by: Austin Abro <[email protected]> Signed-off-by: Brandt Keller <[email protected]>
AustinAbro321
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for
--durationtozarf tools gen-pkiin order to support a more composable model of custom certificate requirements.This is then made compatible with the zarf agent tls (as outlined in the issue) by allowing
zarf initto accept agent tls ca,cert,key.# generate tls ca,cert,key with a 10 year duration zarf tools gen-pki agent-hook.zarf.svc --duration 87600h# pass provided tls information above to zarf init zarf init --agent-tls-ca tlstest/tls.ca --agent-tls-cert tlstest/tls.crt --agent-tls-key tlstest/tls.keyRelated Issue
Fixes #4767
Relates to #
Checklist before merging