feat: stop managing scale down policy in CLI#4725
Merged
Merged
Conversation
Signed-off-by: Austin Abro <[email protected]>
Signed-off-by: Austin Abro <[email protected]>
✅ Deploy Preview for zarf-docs canceled.
|
Signed-off-by: Austin Abro <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
brandtkeller
approved these changes
Mar 19, 2026
Member
brandtkeller
left a comment
brandtkeller
left a comment
There was a problem hiding this comment.
Lgtm - I think we need to call out the implications. I don't imagine many people deploy older versions of the init package with newer versions of the CLI - but it could have a minor impact here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We were setting the scale down policy in the cli and in the chart, which goes against ssa, and would cause failures if the field manager was not Zarf. This complexity is unnecessary, as we already have retry logic on image push that will trigger if the pod that is being pushed to is deleted through a HPA scale down
Checklist before merging