HID: alps: fix error return code in alps_input_configured()

XidianGeneral · Jiri Kosina · commit fa8ba6e5dc0e · 2021-03-08T11:33:49.000+01:00
When input_register_device() fails, no error return code is assigned.
To fix this bug, ret is assigned with -ENOENT as error return code.

Reported-by: TOTE Robot &lt;oslab@tsinghua.edu.cn&gt;
Signed-off-by: Jia-Ju Bai &lt;baijiaju1990@gmail.com&gt;
Signed-off-by: Jiri Kosina &lt;jkosina@suse.cz&gt;
diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c
@@ -761,6 +761,7 @@ static int alps_input_configured(struct hid_device *hdev, struct hid_input *hi)
 
 		if (input_register_device(data->input2)) {
 			input_free_device(input2);
+			ret = -ENOENT;
 			goto exit;
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -761,6 +761,7 @@ static int alps_input_configured(struct hid_device hdev, struct hid_input hi)`
`761`	`761`
`762`	`762`	`if (input_register_device(data->input2)) {`
`763`	`763`	`input_free_device(input2);`
	`764`	`+ ret = -ENOENT;`
`764`	`765`	`goto exit;`
`765`	`766`	`}`
`766`	`767`	`}`