net: qrtr: Fix passing invalid reference to qrtr_local_enqueue()

Mani-Sadhasivam · davem330 · commit d28ea1fbbf43 · 2020-05-21T17:04:53.000-07:00
Once the traversal of the list is completed with list_for_each_entry(), the iterator (node) will point to an invalid object. So passing this to qrtr_local_enqueue() which is outside of the iterator block is erroneous eventhough the object is not used. So fix this by passing NULL to qrtr_local_enqueue(). Fixes: bdabad3 ("net: Add Qualcomm IPC router") Reported-by: kbuild test robot <lkp@intel.com> Reported-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c
@@ -854,7 +854,7 @@ static int qrtr_bcast_enqueue(struct qrtr_node *node, struct sk_buff *skb,
 	}
 	mutex_unlock(&qrtr_node_lock);
 
-	qrtr_local_enqueue(node, skb, type, from, to);
+	qrtr_local_enqueue(NULL, skb, type, from, to);
 
 	return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -854,7 +854,7 @@ static int qrtr_bcast_enqueue(struct qrtr_node node, struct sk_buff skb,`
`854`	`854`	`}`
`855`	`855`	`mutex_unlock(&qrtr_node_lock);`
`856`	`856`
`857`		`- qrtr_local_enqueue(node, skb, type, from, to);`
	`857`	`+ qrtr_local_enqueue(NULL, skb, type, from, to);`
`858`	`858`
`859`	`859`	`return 0;`
`860`	`860`	`}`