dmaengine: usb-dmac: Fix PM reference leak in usb_dmac_probe()

YuKuai-huawei · vinodkoul · commit 1da569fa7ec8 · 2021-07-14T10:41:21.000+05:30
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by moving the error_pm label above the pm_runtime_put() in the error path. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yu Kuai <yukuai3@huawei.com> Link: https://lore.kernel.org/r/20210706124521.1371901-1-yukuai3@huawei.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
diff --git a/drivers/dma/sh/usb-dmac.c b/drivers/dma/sh/usb-dmac.c
@@ -855,8 +855,8 @@ static int usb_dmac_probe(struct platform_device *pdev)
 
 error:
 	of_dma_controller_free(pdev->dev.of_node);
-	pm_runtime_put(&pdev->dev);
 error_pm:
+	pm_runtime_put(&pdev->dev);
 	pm_runtime_disable(&pdev->dev);
 	return ret;
 }

Original file line number	Diff line number	Diff line change
`@@ -855,8 +855,8 @@ static int usb_dmac_probe(struct platform_device *pdev)`
`855`	`855`
`856`	`856`	`error:`
`857`	`857`	`of_dma_controller_free(pdev->dev.of_node);`
`858`		`- pm_runtime_put(&pdev->dev);`
`859`	`858`	`error_pm:`
	`859`	`+ pm_runtime_put(&pdev->dev);`
`860`	`860`	`pm_runtime_disable(&pdev->dev);`
`861`	`861`	`return ret;`
`862`	`862`	`}`