Accept threadpool executors for FailsafePlugin through yaml configuration #1722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rameshmalla
requested review from
Joyfolk,
dingxiangfei2009,
fatroom,
gpradeepkrishna and
lukasniemeier-zalando
as code owners
fatroom
reviewed
Apr 4, 2025
...t-autoconfigure/src/main/java/org/zalando/riptide/autoconfigure/DefaultRiptideRegistrar.java
Show resolved
Hide resolved
fatroom
reviewed
Apr 4, 2025
riptide-micrometer/src/main/java/org/zalando/riptide/micrometer/ThreadPoolMetrics.java
Show resolved
Hide resolved
fatroom
added
the
major
Member
|
@rameshmalla please make sure that your commits has verified signature. check the GH documentation on setting it up: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification |
Member
|
@rameshmalla I see you enabled signature, you need to sign commit 162c4c8 as well. |
Signed-off-by: Ramesh Malla <[email protected]>
Signed-off-by: Ramesh Malla <[email protected]>
Signed-off-by: Ramesh Malla <[email protected]>
Member
Author
I think I finally did it 😄 |
Member
|
👍 |
1 similar comment
Member
Author
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1721
Types of changes
Checklist: