Bumped opentelemetry-semconv to the latest version #1700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cberg-zalando
requested review from
Joyfolk,
dingxiangfei2009,
fatroom,
gpradeepkrishna,
lukasniemeier-zalando and
whiskeysierra
as code owners
fatroom
added
the
minor
Member
|
The non existing classes are still used (i.e. HttpStatusCodeSpanDecorator) |
cberg-zalando
force-pushed
the
fix-deprecated-usage-of-SemanticAttributes-class
branch
from
a13a5c0 to
ebbc18f
Compare
Member
Author
Yeah, somehow I overlooked this one class. |
added 2 commits
February 21, 2025 12:12
- Added opentelemetry-semconv-incubating to have access to constants for used attributes - Switched used attributes to be imported from classes replacing SemanticAttributes
cberg-zalando
force-pushed
the
fix-deprecated-usage-of-SemanticAttributes-class
branch
from
ddc2be3 to
eed91ac
Compare
Member
|
👍 |
1 similar comment
|
👍 |
Member
|
Thank you for the contribution! |
cberg-zalando
deleted the
fix-deprecated-usage-of-SemanticAttributes-class
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Latest Obversaviblity SDK 3.1.13 contains a bump of
opentelemetry-semconvfrom 1.28.0-alpha to 1.30.0-rc.1 introducing a breaking change as theio.opentelemetry.semconv.SemanticAttributesclass was removed and replaced with more specific sub class in the sub packageincubating.Nevertheless, looking at the class it had the deprecation marker since version 1.24.0 (Riptide uses 1.25-alpha currently), so I guess, it is the usual issue that these deprecation warnings are overlooked until it is too late.
Motivation and Context
It allows projects using Obversaviblity SDK to use the latest version.
Types of changes