Remove deprecated compatibility layer #1423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@dingxiangfei2009 resttemplate is not deprecated: https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/web/client/RestTemplate.html so we still need compatibility module. It's only AsyncRestTemplate deprecated and removed |
fatroom
reviewed
Mar 1, 2023
dingxiangfei2009
force-pushed
the
deprecate-compatibility
branch
from
b1f30ec to
e7501e1
Compare
dingxiangfei2009
force-pushed
the
deprecate-compatibility
branch
from
e7501e1 to
d33157c
Compare
dingxiangfei2009
changed the title
dingxiangfei2009
requested review from
Joyfolk,
Semernitskaya,
gpradeepkrishna,
lukasniemeier-zalando and
whiskeysierra
as code owners
Member
|
@dingxiangfei2009 thank you for your contribution! |
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #1393
This PR removes
AsyncHttpOperationsin preparation of Riptide 4.Question do we still need to keep
riptide-compatibility?Motivation and Context
RestTemplateandAsyncRestTemplateare deprecated in Spring 4 and removed in Spring 6. Because of this, we are removing the facades from the compatibility mode.Types of changes
Checklist: