Bugfix: Implement bracketSameLine options for html tags#104
Merged
Conversation
This parameter is required to conditionally build doc object that would allow placement of opening tag end.
By default, option `bracketSameLine` is set to `false` and behave differently before fixed in this patch set. Thus we need to update existing snapshot to adhere with this changes.
zackad
force-pushed
the
GH-90/bracket-same-line
branch
from
5686668 to
8293679
Compare
rellafella
approved these changes
Dec 16, 2024
Collaborator
rellafella
left a comment
rellafella
left a comment
There was a problem hiding this comment.
Definitely some big changes coming across people's code bases with this one but thankfully it is configured correctly now.
Nothing for me to add here, looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close GH-90
I'm marking this as a draft since there's refactoring I want to do for test setup and commit history cleanup. Just want to make sure that everything is working as expected.By default option
bracketSameLineis set tofalse, and we need to update existing snapshot test.