Correct extended DSK signature#2530
Merged
suborb merged 2 commits intoz88dk:masterfrom May 9, 2024
damieng:patch-1
Merged
Conversation
Member
|
Good spot, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The disk signature for generated .dsk files is slightly incorrect causing the image to not be loadable into various tools such as Spectaculator and Disk Image Manager.
The spec at https://www.cpcwiki.eu/index.php/Format:DSK_disk_image_file_format indicates that offset 00 should include the sequence:
"EXTENDED CPC DSK File\r\nDisk-Info\r\n"Unfortunately it is generated with the wrong case right now as the word File has been capitalized. Manually editing the signature in generated disk images indicated the image is otherwise correct.