Replace chalk with picocolors#32
Merged
haoqunjiang merged 1 commit intoyyx990803:masterfrom Dec 20, 2021
Merged
Conversation
This is another take to make vite install size smaller. Currently vite bundles two instances of chalk. v2 from this package and v4 in own code. Both are quite big https://packagephobia.com/[email protected] https://packagephobia.com/[email protected] I suggest to replace it with micropackage which became quite popular recently https://packagephobia.com/result?p=picocolors https://www.npmtrends.com/picocolors
haoqunjiang
approved these changes
Dec 20, 2021
Contributor
Author
|
@sodatea @yyx990803 Would it be possible to release new version? I want to use it in vite. |
Collaborator
|
Yeah, in a few hours. |
TrySound
added a commit
to TrySound/vite
that referenced
this pull request
Dec 21, 2021
See yyx990803/launch-editor#32 Chalk 2 is removed from vite bundle ``` du -ck dist/node ``` before: 12268 after: 12116
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another take to make vite install size smaller.
Currently vite bundles two instances of chalk. v2 from this package
and v4 in own code.
Both are quite big
https://packagephobia.com/[email protected]
https://packagephobia.com/[email protected]
I suggest to replace it with micropackage which became quite popular
recently
https://packagephobia.com/result?p=picocolors
https://www.npmtrends.com/picocolors