Repository navigation
[misc] Use ini_options table for pytest config - #17952
Merged
Merged
Conversation
de445c9 changed this mode 6 months ago, presumably because using native toml is cleaner but pytest 9.2 makes this complicated. it has a regression that no longer accepts verbosity options as string-typed integers, whereas earlier versions accepted no other format, and they clearly intend to deprecate the old format pytest-dev/pytest#15290 the only future-proof options are to test for the pytest version every time, require >=9.2 (which is too new to be a dependency anyway) or to switch back to ini mode, as this does.
bashonly
approved these changes
Oct 29, 2026
bashonly
left a comment
Member
There was a problem hiding this comment.
I had completely forgotten ini_options was a thing. Thanks!
ini_options table for pytest config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your pull request and other information
de445c9 changed this mode 6 months ago, presumably because using native toml is cleaner
but pytest 9.2 makes this complicated. it has a regression that no longer accepts verbosity options as string-typed integers, whereas earlier versions accepted no other format, and they clearly intend to deprecate the old format pytest-dev/pytest#15290
the only future-proof options are to test for the pytest version every time, require >=9.2 (which is too new to be a dependency anyway) or to switch back to ini mode, as this does.
Fixes #17951
Template
Before submitting a pull request you must attest to the following:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check those that apply and remove the others:
What is the purpose of your pull request? Check those that apply and remove the others: