Skip to content

Revert "Enable Evergreen sideloading" - #8703

Merged
yuying-y merged 1 commit into
25.lts.1+from
revert-6105-enable_sideloading
Jan 16, 2026
Merged

yuying-y merged 1 commit into
25.lts.1+from
revert-6105-enable_sideloading

Conversation

@yuying-y

Copy link
Copy Markdown
Contributor

Reverts #6105 because 25.lts.40 will be released, and this feature is disabled pending the additional security review b/473616636

@github-actions

Copy link
Copy Markdown
Contributor

🤖 Gemini Suggested Commit Message


evergreen: Revert "Enable Evergreen sideloading"

This commit reverts the functionality to enable Evergreen sideloading.
The feature is temporarily disabled by modifying updater and H5VCC
preprocessor directives to respect ALLOW_EVERGREEN_SIDELOADING, which
is now defined as 0 in Starboard configuration.

This action is taken because the 25.lts.40 release is approaching and
the Evergreen sideloading feature requires additional security review
before it can be fully enabled.

Bug: 473616636

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts the 'Enable Evergreen sideloading' feature, disabling it pending a security review. The changes introduce a compile-time flag ALLOW_EVERGREEN_SIDELOADING and use it to conditionally compile out the feature's code. The implementation is correct and consistent across all modified files. I have reviewed the changes and found no issues.

@yuying-y
yuying-y requested a review from oxve January 15, 2026 23:29
@yuying-y
yuying-y force-pushed the revert-6105-enable_sideloading branch from da71180 to c2e478e Compare January 16, 2026 18:57
@yuying-y
yuying-y enabled auto-merge (squash) January 16, 2026 22:19
@yuying-y
yuying-y merged commit 4fe751a into 25.lts.1+ Jan 16, 2026
344 of 346 checks passed
@yuying-y
yuying-y deleted the revert-6105-enable_sideloading branch January 16, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants