Repository navigation
regenerate multi-root-test-chain certs - #8649
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully regenerates the multi-root test certificates and updates the associated test cases and scripts. The changes correctly reflect the new certificate properties, including updated validity periods and serial numbers. The test assertions in nss_cert_database_unittest.cc have been adjusted to match the new order of certificates, and the generate-multi-root-test-chains.sh script now explicitly uses python3, which is a good practice for script maintainability. No issues of medium, high, or critical severity were found.
kaidokert
left a comment
kaidokert
left a comment
There was a problem hiding this comment.
Straight cherrypick, it should work ?
were getting more test failures with this unfortunately |
Out of date test cert is failing net unittest. Branch is stable, cert will not be updated. Bug: 278599663
Regenerates the test certificates from the scripts generate-multi-root-test-chains.sh and generate-multi-root-keychain.sh
Bug: 40802244
Change-Id: Ie9ec231c1fc6e3ee1c46d7908c62f8a66fdab79b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7032484
Commit-Queue: Matt Mueller [email protected]
Reviewed-by: Hubert Chao [email protected]
Cr-Commit-Position: refs/heads/main@{#1530398}
Cherry-picked from: a6a5d55a2473e8eda675bf7a9da1671c39a13fea
Bug: 278599663