Repository navigation
Update ssl certs using pem files from google3. - #8574
Conversation
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the SSL root certificates by removing several old certificates and adding three new ones. The build configuration in cobalt/network/certs.gni is updated accordingly, and the list of certificates remains correctly sorted. The changes appear to be a routine certificate update from an upstream source, as indicated in the pull request description.
Per the repository's style guide, changes that are backports or cherry-picks from an upstream source do not require a detailed code review. My review confirms that the patch is applied correctly and is consistent across all file changes. Therefore, I approve this pull request.
|
ping on this - can we get this landed ? |
googledata/security/ctlog/ca_certificates/chrome/chrome_roots.pem and security/cacerts/for_connecting_to_google/roots.pem were used with Cobalt's update_certs.py script. Bug: 278599663
googledata/security/ctlog/ca_certificates/chrome/chrome_roots.pem and
security/cacerts/for_connecting_to_google/roots.pem were used with Cobalt's update_certs.py script.
Update cross-signed-*.pem
cross-signed-leaf.pem
cross-signed-root-md5.pem
cross-signed-root-sha256.pem
Cherry-picked from I6d6b77beb2b222acb470010099b79eae6556e12c
Bug: 278599663