Repository navigation
Fix potential SIGSEGV in SbSocketWaiterPrivate initialization - #8464
Merged
Merged
Conversation
Contributor
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The change correctly addresses a potential SIGSEGV crash in release builds by replacing SB_DCHECK with SB_CHECK for validating the server_socket. This ensures that critical validation occurs in all build configurations, preventing undefined behavior and improving the stability of the application.
amurovanyi
self-requested a review
December 18, 2025 15:57
victorpasoshnikov
self-requested a review
December 19, 2025 14:00
msolya
changed the title
Replace SB_DCHECK with SB_CHECK when validating server_socket in GetSocketPipe(). SB_DCHECK is compiled out in Release builds, leading to undefined behavior (null pointer dereference) when AcceptBySpinning() fails or times out. This UB manifests as SIGSEGV crash at line 146 when accessing server_socket_->socket_fd. SB_CHECK ensures validation in all build configurations and provides clear error message on failure instead of unpredictable crash.
msolya
force-pushed
the
fix_socket_crash
branch
from
February 16, 2026 10:31
83e4513 to
47b5aa8
Compare
msolya
changed the title
victorpasoshnikov
approved these changes
Feb 16, 2026
kaidokert
approved these changes
Feb 17, 2026
kaidokert
left a comment
kaidokert
left a comment
Contributor
There was a problem hiding this comment.
Looks fine to me - better clear crash here thatn invisibly failing.
@jellefoks thoughts ?
jellefoks
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace SB_DCHECK with SB_CHECK when validating server_socket in GetSocketPipe().
SB_DCHECK is compiled out in Release builds, leading to undefined behavior (null pointer dereference) when AcceptBySpinning() fails or times out. This UB manifests as SIGSEGV crash at line 146 when accessing server_socket_->socket_fd.
SB_CHECK ensures validation in all build configurations and provides clear error message on failure instead of unpredictable crash.