Repository navigation
Cherry pick PR #8421: android: Reset operating frame rate during flush - #8459
Merged
Merged
Conversation
When the MediaCodecBridge is flushed, the previously estimated operating frame rate becomes invalid. Resetting the frame rate estimator ensures that new frame rate calculations start from a clean state after a flush, preventing stale or incorrect frame rate data from affecting playback or adaptation logic. This is important for accurate media synchronization and performance on Android. Issue: 467911298 Issue: 320568573 (cherry picked from commit ef8d720)
Contributor
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
borongc
approved these changes
Dec 18, 2025
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a cherry-pick to reset the operating frame rate estimator during a media codec flush. The logic to perform this reset within a finally block is sound, ensuring it executes regardless of whether the flush operation succeeds or fails. I have added one suggestion to improve the robustness of the exception handling, which is a good practice for cleanup code in finally blocks.
johnxwork
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #8421
When the MediaCodecBridge is flushed, the previously estimated operating
frame rate becomes invalid. Resetting the frame rate estimator ensures
that new frame rate calculations start from a clean state after a flush,
preventing stale or incorrect frame rate data from affecting playback
or adaptation logic. This is important for accurate media synchronization
and performance on Android.
Issue: 467911298
Issue: 320568573