Repository navigation
android: Reset operating frame rate during flush - #8421
Merged
Merged
Conversation
Contributor
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a call to reset the frame rate estimator when the media codec is flushed. The change is logical, as flushing the codec is a reset operation. I have one suggestion to improve the error handling to make debugging easier in case of an unexpected failure.
borongc
changed the title
borongc
force-pushed
the
seek_mediacodec
branch
from
December 16, 2025 03:10
39014a3 to
48e31ea
Compare
Member
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly identifies the need to reset the frame rate estimator when the media codec is flushed. The implementation is straightforward and handles potential errors by returning an error status, which is consistent with the existing code. I have one suggestion to improve the exception handling to better align with the project's style guide by using a more specific exception type.
borongc
force-pushed
the
seek_mediacodec
branch
2 times, most recently
from
December 17, 2025 00:11
dbe4890 to
dddb2d0
Compare
jasonzhangxx
approved these changes
Dec 17, 2025
borongc
force-pushed
the
seek_mediacodec
branch
2 times, most recently
from
December 17, 2025 02:40
dbe4890 to
3d2e612
Compare
yell0wd0g
approved these changes
Dec 17, 2025
yell0wd0g
left a comment
yell0wd0g
left a comment
Contributor
There was a problem hiding this comment.
LGTM with a suggestion.
borongc
force-pushed
the
seek_mediacodec
branch
from
December 17, 2025 08:42
3d2e612 to
729713f
Compare
borongc
added
cp-25.lts.1+
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Dec 18, 2025
When the MediaCodecBridge is flushed, the previously estimated operating frame rate becomes invalid. Resetting the frame rate estimator ensures that new frame rate calculations start from a clean state after a flush, preventing stale or incorrect frame rate data from affecting playback or adaptation logic. This is important for accurate media synchronization and performance on Android. Issue: 467911298 Issue: 320568573 (cherry picked from commit ef8d720)
johnxwork
pushed a commit
that referenced
this pull request
Dec 18, 2025
#8459) Refer to the original PR: #8421 When the MediaCodecBridge is flushed, the previously estimated operating frame rate becomes invalid. Resetting the frame rate estimator ensures that new frame rate calculations start from a clean state after a flush, preventing stale or incorrect frame rate data from affecting playback or adaptation logic. This is important for accurate media synchronization and performance on Android. Issue: 467911298 Issue: 320568573 Co-authored-by: Bo-Rong Chen <[email protected]>
borongc
added a commit
that referenced
this pull request
Dec 18, 2025
Refer to the original PR: #8421 When the MediaCodecBridge is flushed, the previously estimated operating frame rate becomes invalid. Resetting the frame rate estimator ensures that new frame rate calculations start from a clean state after a flush, preventing stale or incorrect frame rate data from affecting playback or adaptation logic. This is important for accurate media synchronization and performance on Android. Issue: 467911298 Issue: 320568573
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the MediaCodecBridge is flushed, the previously estimated operating
frame rate becomes invalid. Resetting the frame rate estimator ensures
that new frame rate calculations start from a clean state after a flush,
preventing stale or incorrect frame rate data from affecting playback
or adaptation logic. This is important for accurate media synchronization
and performance on Android.
Issue: 467911298
Issue: 320568573