Repository navigation
starboard: Cherry pick PR #8053: Fix DNS lookups for IPv6 addresses. - #8367
Merged
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a cherry-pick of an upstream change to fix DNS lookups for IPv6 addresses. The core fix in starboard/shared/modular/starboard_layer_posix_socket_abi_wrappers.cc correctly addresses an issue with copying sockaddr structures for IPv6 by ensuring the entire structure is copied. This is accompanied by robust test enhancements in starboard/nplb/posix_compliance/posix_socket_resolve_test.cc to validate the fix for both IPv4 and IPv6. The pull request also includes a significant refactoring, moving responsibilities from cobalt/browser to cobalt/shell and improving Android connectivity detection logic. In accordance with the repository's style guide for cherry-picks, this review focused on the correct application of the patch. The changes are extensive but appear to be self-consistent and correctly integrated.
yell0wd0g
reviewed
Dec 11, 2025
The Starboard layer wrapper for getaddrinfo() made incorrect copies of the address returned for IPv6 addresses. This fixes that and adds extensive testing using a host with known IP addresses. The fix is adopted from youtube#7588 with a simplification and additional tests. This PR also includes an update to test certs for net_unittests that expired Oct 29 2025. Bug: 460175900 Bug: 438858995 Bug: 409716671 Bug: 460594994 Bug: 439002238 Bug: 405988446 --------- Co-authored-by: jimmy.ge <[email protected]>
jellefoks
force-pushed
the
dns6_lookup_fix_main
branch
from
December 15, 2025 19:36
9e3163f to
e25bc15
Compare
yell0wd0g
approved these changes
Dec 16, 2025
yell0wd0g
left a comment
yell0wd0g
left a comment
Contributor
There was a problem hiding this comment.
Whoops didn't see my +1 was needed. Doing it now
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Dec 16, 2025
…8367) Refer to the original PR: #8053 The Starboard layer wrapper for getaddrinfo() made incorrect copies of the sockaddr structure for IPv6 addresses. This issue prevented proper resolution and use of IPv6 addresses for DNS lookups. This change modifies the wrapper to ensure that the entire sockaddr structure, including the address data, is correctly copied, thus resolving the IPv6 address lookup failures. Additionally, extensive tests have been added and updated to thoroughly verify both IPv4 and IPv6 address resolution for known external hosts and localhost. Bug: 460175900 Bug: 438858995 Bug: 409716671 Bug: 460594994 Bug: 439002238 Bug: 405988446 Co-authored-by: jimmy.ge <[email protected]> (cherry picked from commit 2280057)
jellefoks
added a commit
that referenced
this pull request
Dec 16, 2025
…s for IPv6 addresses. (#8428) Refer to the original PR: #8367 Refer to the original PR: #8053 The Starboard layer wrapper for getaddrinfo() made incorrect copies of the sockaddr structure for IPv6 addresses. This issue prevented proper resolution and use of IPv6 addresses for DNS lookups. This change modifies the wrapper to ensure that the entire sockaddr structure, including the address data, is correctly copied, thus resolving the IPv6 address lookup failures. Additionally, extensive tests have been added and updated to thoroughly verify both IPv4 and IPv6 address resolution for known external hosts and localhost. Bug: 460175900 Bug: 438858995 Bug: 409716671 Bug: 460594994 Bug: 439002238 Bug: 405988446 Co-authored-by: Jelle Foks <[email protected]> Co-authored-by: jimmy.ge <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #8053
The Starboard layer wrapper for getaddrinfo() made incorrect copies of
the sockaddr structure for IPv6 addresses. This issue prevented proper
resolution and use of IPv6 addresses for DNS lookups.
This change modifies the wrapper to ensure that the entire sockaddr
structure, including the address data, is correctly copied, thus
resolving the IPv6 address lookup failures. Additionally, extensive
tests have been added and updated to thoroughly verify both IPv4 and
IPv6 address resolution for known external hosts and localhost.
Bug: 460175900
Bug: 438858995
Bug: 409716671
Bug: 460594994
Bug: 439002238
Bug: 405988446