Repository navigation
[26.android] Fix all highest level [5] cpplint errors - #7897
Merged
Merged
Conversation
johnxwork
approved these changes
Nov 5, 2025
johnxwork
enabled auto-merge (squash)
November 5, 2025 20:07
kaidokert
approved these changes
Nov 5, 2025
kaidokert
left a comment
kaidokert
left a comment
Contributor
There was a problem hiding this comment.
Thanks for catching this branch up too ! Looks low-risk and the changes are non-functional
Collaborator
Author
Of course! Thanks for the quick review @johnxwork and @kaidokert |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable
cpplintand fix all [5] errors, bringing this branch to parity withmain(m138). (Similar change has been submitted for 26.eap.) This will reduce merge commit friction between26.androidandmain. Errors are mostly header guard and basic formatting errors. Follow up from #7808, where we'd prefer not to just cherry-pick that PR since some files don't exist in 26.android (e.g. starboard/link_receiver.cc).Bug: 455923882