Repository navigation
Fix all highest level [5] cpplint errors - #7808
Conversation
|
Will follow up with addressing [4] errors. |
… and exclude. Not building.
andrewsavage1
left a comment
andrewsavage1
left a comment
There was a problem hiding this comment.
This seems like good cleanup, but making changes like this in the main branch when we are developing in multiple branches (main, 26.android, and 26.eap) can be annoying when cherry-picking isn't clean. Would you be able to check if #7783 and then this change apply cleanly to the 26.eap branch as well?
Discussed offline. I tried cherry-picking but there are a lot of files that don't exist in 26.android and 26.eap. We think it will be easier to just run cpplint on those branches separately. The lint errors that get fixed at [5] should generally be straightforward - like incorrect header guards and random semicolons in places. |
Enable `cpplint` and fix all [5] errors, bringing this branch to parity with `main` (m138). This will reduce merge commit friction between `26.eap` and `main`. Errors are mostly header guard and basic formatting errors. Follow up from #7808, where we'd prefer not to just cherry-pick that PR since some files don't exist in 26.eap (e.g. starboard/version.h). Bug: 455923882
Enable `cpplint` and fix all [5] errors, bringing this branch to parity with `main` (m138). (Similar change has been submitted for 26.eap.) This will reduce merge commit friction between `26.android` and `main`. Errors are mostly header guard and basic formatting errors. Follow up from #7808, where we'd prefer not to just cherry-pick that PR since some files don't exist in 26.android (e.g. starboard/link_receiver.cc). Bug: 455923882
The cpplint tool (Google C++ style) was added in C25 and cherry-picked into main (m138) in #7783. This PR fixes all highest level [5] errors that exist in the codebase. (In theory your PRs shouldn't be blocked by errors in files you don't touch.) These errors are mostly header guard, missing copyright, missing header inclusion, and syntax errors (missing terminating newline).
Bug: 456554108