Repository navigation
Conversation
jonastsai
requested review from
cobalt-github-releaser-bot,
jellefoks and
kaidokert
November 10, 2025 07:45
Member
|
@jellefoks , I recall we discussed this was a reasonable change. Can you take a quick look? |
Member
|
Thanks for submitting this. I used this fix in #8053 after fixing the line formatting and adding tests that confirm that this fix works (the tests added fail without this fix). |
jellefoks
added a commit
that referenced
this pull request
Nov 17, 2025
The Starboard layer wrapper for getaddrinfo() made incorrect copies of the address returned for IPv6 addresses. This fixes that and adds extensive testing using a host with known IP addresses. The fix is adopted from #7588 with a simplification and additional tests. This PR also includes an update to test certs for net_unittests that expired Oct 29 2025. Bug: 460175900 Bug: 438858995 Bug: 409716671 Bug: 460594994 Bug: 439002238 Bug: 405988446 --------- Co-authored-by: jimmy.ge <[email protected]>
Member
jellefoks
added a commit
that referenced
this pull request
Dec 11, 2025
The Starboard layer wrapper for getaddrinfo() made incorrect copies of the address returned for IPv6 addresses. This fixes that and adds extensive testing using a host with known IP addresses. The fix is adopted from #7588 with a simplification and additional tests. This PR also includes an update to test certs for net_unittests that expired Oct 29 2025. Bug: 460175900 Bug: 438858995 Bug: 409716671 Bug: 460594994 Bug: 439002238 Bug: 405988446 --------- Co-authored-by: jimmy.ge <[email protected]>
jellefoks
added a commit
to jellefoks/cobalt
that referenced
this pull request
Dec 11, 2025
The Starboard layer wrapper for getaddrinfo() made incorrect copies of the address returned for IPv6 addresses. This fixes that and adds extensive testing using a host with known IP addresses. The fix is adopted from youtube#7588 with a simplification and additional tests. This PR also includes an update to test certs for net_unittests that expired Oct 29 2025. Bug: 460175900 Bug: 438858995 Bug: 409716671 Bug: 460594994 Bug: 439002238 Bug: 405988446 --------- Co-authored-by: jimmy.ge <[email protected]>
jellefoks
added a commit
to jellefoks/cobalt
that referenced
this pull request
Dec 15, 2025
The Starboard layer wrapper for getaddrinfo() made incorrect copies of the address returned for IPv6 addresses. This fixes that and adds extensive testing using a host with known IP addresses. The fix is adopted from youtube#7588 with a simplification and additional tests. This PR also includes an update to test certs for net_unittests that expired Oct 29 2025. Bug: 460175900 Bug: 438858995 Bug: 409716671 Bug: 460594994 Bug: 439002238 Bug: 405988446 --------- Co-authored-by: jimmy.ge <[email protected]>
msolya
pushed a commit
to msolya/cobalt
that referenced
this pull request
Mar 6, 2026
The Starboard layer wrapper for getaddrinfo() made incorrect copies of the address returned for IPv6 addresses. This fixes that and adds extensive testing using a host with known IP addresses. The fix is adopted from youtube#7588 with a simplification and additional tests. This PR also includes an update to test certs for net_unittests that expired Oct 29 2025. Bug: 460175900 Bug: 438858995 Bug: 409716671 Bug: 460594994 Bug: 439002238 Bug: 405988446 --------- Co-authored-by: jimmy.ge <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is to fix the error in getting the socket address on IPv6 networks
Bug:401441408