Repository navigation
Fix the touch panel crash - #7214
Merged
Merged
Conversation
jonastsai
self-requested a review
September 26, 2025 01:39
Member
|
@andrewsavage1 , this seems like a reasonable change for more robust handling of a NULL ptr situation. Any thoughts on this? |
| DCHECK(base::SequencedTaskRunner::GetCurrentDefault() == | ||
| scroll_engine_.task_runner()); | ||
|
|
||
| if (!scroll_container) { |
Contributor
There was a problem hiding this comment.
This seems unnecessary if it's also being added in topmost_event_target.cc
Contributor
Author
There was a problem hiding this comment.
ScrollEngine::HandleScrollStart is only called by TopmostEventTarget::HandleScrollState.
you are right. Let me remove it. thanks
prevent element_to_scroll->GetUiNavItem() nullptr being utilized by other function and crash
andrewsavage1
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A crash occurs during vertical scrolling. The crash was caused by the scroll engine receiving a null pointer.
The
FindFirstElementWithScrollTypefunction intopmost_event_target.ccwas returning a scrollable element that did not have an associatedUiNavItemfor vertical scroll events. This led to a null pointer being passed to thescroll_engine, causing the application to crash.This change ensure scrollable element has a valid
UiNavItembefore calling scroll_engineBug: 426634950