Repository navigation
Add video renderer extension - #6454
Merged
Merged
Conversation
amurovanyi
approved these changes
Sep 1, 2025
victorpasoshnikov
approved these changes
Sep 1, 2025
kaidokert
reviewed
Sep 16, 2025
Contributor
|
/gemini review |
kaidokert
approved these changes
Sep 16, 2025
kaidokert
left a comment
kaidokert
left a comment
Contributor
There was a problem hiding this comment.
Otherwise looks okay to submit, just would be good to take opportunity to unify the naming.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new extension to allow custom video frame rendering. The implementation is a good start, but I have a few important suggestions. In textured_mesh_renderer.cc, the extension pointer should be cached to avoid repeated lookups in the performance-sensitive RenderVBO function. More critically, the new video_renderer.h extension header has a layering violation by depending on Cobalt-specific types. The API should be refactored to use platform-agnostic types to maintain a clean separation between Cobalt and Starboard.
b/178105735 This commit adds extension that allows to replace the default rendering of video frames.
alexanderbobrovnik
force-pushed
the
b1781-4
branch
from
September 24, 2025 14:21
4e5a157 to
5a47a9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/178105735
This commit adds extension that allows to replace the default rendering of video frames.