Skip to content

rename rdk executable to use default name - #6345

Merged
jonastsai merged 2 commits into
youtube:25.lts.1+from
jonastsai:b-421431143_rename_rdk_loader
Jul 31, 2025
Merged

rename rdk executable to use default name#6345
jonastsai merged 2 commits into
youtube:25.lts.1+from
jonastsai:b-421431143_rename_rdk_loader

Conversation

@jonastsai

@jonastsai jonastsai commented Jul 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Remove _bin at the executable file name in RDK so that
the way to launch unittest is aligned with other platforms.

Bug: b/421431143

@jonastsai jonastsai added the on_device Trigger on-device tests label Jul 9, 2025
yell0wd0g
yell0wd0g reviewed Jul 9, 2025
View reviewed changes

@yell0wd0g yell0wd0g left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of editorial nits: The PR description doesn't
say why you do this, only a summary of what's being
done ("remove _bin at the end of the executable
filename").

The CL/PR title doesn't give a clue of what's being
touched, I suggest prefixing it with "starboard".

I.e.

starboard: rename executable ...

This PR change bla to foo to allow for this and
that. 
Tested by XYZ on ABC.

Bug: b/421431143

(Note the Bug: prefixing the buganizer issue, IIRC this
was needed for some subsystem to pick up gerrit CLs and
annotate the bug; also IIRC just the b/123 is not enough.)

Once all that is done perhaps @andrewsavage1 could stand
in for @niranjanyardi ?

@jonastsai
jonastsai force-pushed the b-421431143_rename_rdk_loader branch from 0fa6631 to cbf39de Compare July 10, 2025 13:25
@jonastsai

jonastsai commented Jul 10, 2025

Copy link
Copy Markdown
Contributor Author

Thanks Miguel for the comments. I have updated the comment to include more information regarding the change.

For the ticket number, I checked the Cobalt commits and 90% of the changes use b/123456 directly and they can actually linked to the ticket. So that I keep it as it was.

@jonastsai
jonastsai requested a review from andrewsavage1 July 10, 2025 13:30
@andrewsavage1

andrewsavage1 commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

For the ticket number, I checked the Cobalt commits and 90% of the changes use b/123456 directly and they can actually linked to the ticket. So that I keep it as it was.

You should change it to Bug: 123 as Miguel suggested, as the system to associate submitted changes with buganizer bugs changed a few months ago to not recognize the b/123 format.

@jonastsai

jonastsai commented Jul 10, 2025

Copy link
Copy Markdown
Contributor Author

For the ticket number, I checked the Cobalt commits and 90% of the changes use b/123456 directly and they can actually linked to the ticket. So that I keep it as it was.

You should change it to Bug: 123 as Miguel suggested, as the system to associate submitted changes with buganizer bugs changed a few months ago to not recognize the b/123 format.

Should I use Bug: 123 or Bug: b/123

@andrewsavage1

andrewsavage1 commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

Should I use Bug: 123 or Bug: b/123

Either is fine, see go/gitwatcher

@jonastsai
jonastsai force-pushed the b-421431143_rename_rdk_loader branch from cbf39de to a5fff57 Compare July 10, 2025 15:03
@jonastsai

jonastsai commented Jul 10, 2025

Copy link
Copy Markdown
Contributor Author

Should I use Bug: 123 or Bug: b/123

Either is fine, see go/gitwatcher

Thanks you! The commit command is updated.

@jonastsai
jonastsai requested a review from niranjanyardi July 21, 2025 01:15
niranjanyardi
niranjanyardi approved these changes Jul 21, 2025
View reviewed changes

@niranjanyardi niranjanyardi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once you move the changes under starboard/contrib/rdk to the gerrit repo, this looks good to me

@jonastsai
jonastsai force-pushed the b-421431143_rename_rdk_loader branch from a5fff57 to 887d658 Compare July 27, 2025 12:50
@jonastsai

jonastsai commented Jul 27, 2025

Copy link
Copy Markdown
Contributor Author

Hi @niranjanyardi, I have moved the changes in starboard/contrib/rdk to gerrit. please help to check it again. Thanks.

@jonastsai
jonastsai force-pushed the b-421431143_rename_rdk_loader branch from d95ad19 to 86efcf1 Compare July 29, 2025 11:46
@jonastsai
jonastsai enabled auto-merge (squash) July 30, 2025 03:53
@jonastsai
jonastsai disabled auto-merge July 30, 2025 08:19
jonastsai added 2 commits July 31, 2025 09:51
@jonastsai
Rename RDK loader_app and elf_loader_sandbox executable
d66c974 
Remove _bin at the executable file name in RDK so that
the way to launch unittest is aligned with other platform.

Bug: b/421431143
@jonastsai
Squashed 'starboard/contrib/rdk/' changes from b9111ae7e92..e82a5ade6fa
37424d2 
e82a5ade6fa Rename RDK loader_app and elf_loader_sandbox executable
aa721db4091 Add support files required to run RDK tests using `cobalt/starboard/tools/testing/test_runner.py`
ecce60e22f3 Add default args to build RDK

git-subtree-dir: starboard/contrib/rdk
git-subtree-split: e82a5ade6fa3be4b0c802955f147ca812550b620
@jonastsai
jonastsai force-pushed the b-421431143_rename_rdk_loader branch from 86efcf1 to 37424d2 Compare July 31, 2025 01:51
@jonastsai
jonastsai merged commit ebebcea into youtube:25.lts.1+ Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yell0wd0g yell0wd0g yell0wd0g left review comments
@niranjanyardi niranjanyardi niranjanyardi approved these changes
@andrewsavage1 andrewsavage1 andrewsavage1 left review comments

Assignees

No one assigned

Labels

on_device Trigger on-device tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonastsai @andrewsavage1 @yell0wd0g @niranjanyardi