Repository navigation
Add support for running RDK tests using starboard/tools/testing/test_runner.py - #5689
Conversation
149fc84 to
d56da2f
Compare
niranjanyardi
left a comment
niranjanyardi
left a comment
There was a problem hiding this comment.
can we move all files under starboard/rdk to somewhere inside starboard/contrib/rdk ?
|
@hlwarriner / @yuying-y can you ptal at the evergreen launcher changes ? |
|
Two issues I encountered so far with your change:
|
@andrunko ptal |
d56da2f to
6c4e8bc
Compare
We could but as explained offline, we would need to duplicate basically all files for each platform RDK supports (atm we only support arm, but upstream also supports arm64 and rpi), due to the fact that the RDK sources don't have a fixed location (can change depending on a build var). Also this script ( That said, I would keep them where they are, but please let me know what you think and if needed I can updated. |
As mentioned elsewhere, please use
This should be fixed with latest changes, please let me know of any issue. |
andre to create a follow up bug here |
hlwarriner
left a comment
hlwarriner
left a comment
There was a problem hiding this comment.
Mostly lgtm but I left a few comments for the evergreen launcher changes.
48293bd to
a4d1b7d
Compare
jonastsai
left a comment
jonastsai
left a comment
There was a problem hiding this comment.
I confirm the new PR works with my RDK CB25 image. It can run all the unittest which includes NPLB.
02aa61b to
63a50ab
Compare
hlwarriner
left a comment
hlwarriner
left a comment
There was a problem hiding this comment.
LGTM as long as the open comment is addressed before merging - thanks.
niranjanyardi
left a comment
niranjanyardi
left a comment
There was a problem hiding this comment.
Please add a TODO in starboard/rdk/launcher.py
somewhere at the begnining of the file. maybe around line 33
Something like
// TODO(b/xxxxxxxx): Move all files under starboard/rdk to starboard/contrib/rdk
Ack, will add the TODO - should we say "Consider moving all files..." instead? Given there are the other constraints we discussed previously (e.g. duplicating code when supporting multiple rdk platforms, etc) to weight in before actuall moving it? |
…_runner.py` This updates the current RDK test launcher to use the `elf_loader_sandbox` to run the tests, similar to other linux platforms, opposed to using a `jsonrpc` call. Also update ssh/rsync options to properly connect to devices using a default RDK setup. b/415848657
…t_runner.py` for raspi tests The current implementation relies in the `first_run` entry being available on `globals()`, but this was always true given `globals()` also includes method names which was the case (i.e. `first_run()`), so let's rename it. b/415848657
This should fix tests that require video playback. b/415848657
63a50ab to
9644561
Compare
|
I believe I've addressed all feedback, please let me know if I missed something. |
This updates the current RDK test launcher to use the
elf_loader_sandboxto run the tests, similar to other linux platforms, opposed to using ajsonrpccall.The test launcher script will use SSH/rsync to connect/copy resources to the device, so for it to work the SSH device configuration should be based on https://wiki.rdkcentral.com/display/RDK/Test+on+board, including the default ports listed there.
This PR also includes a small bugfix for the Raspi test launcher when using
test_runner.py.b/415848657