Repository navigation
Add default args to build RDK using gn.py locally - #5671
Merged
Merged
Conversation
Member
Author
|
Verfied that this works locally using these commands : https://b.corp.google.com/issues/415836017#comment2 |
niranjanyardi
marked this pull request as ready for review
May 5, 2025 23:50
Contributor
|
The change make sense to me. The only question in my mind is where is the starting point to place this change. |
oxve
approved these changes
May 6, 2025
Member
Author
talked to @oxve , im going to submit it here and cherry-pick to google source |
niranjanyardi
force-pushed
the
25lts_rdk_gn_args
branch
from
May 6, 2025 22:27
7488b2b to
1a8951f
Compare
niranjanyardi
enabled auto-merge
May 6, 2025 22:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/415836017
Modify default args.gn to build RDK platform outside Yocto build environment