Skip to content

Add RDK repo at external/components/generic/cobalt under starboard/contrib/rdk - #5621

Merged
niranjanyardi merged 2 commits into
youtube:25.lts.1+from
niranjanyardi:25lts_add_rdk_repo
May 1, 2025
Merged

niranjanyardi merged 2 commits into
youtube:25.lts.1+from
niranjanyardi:25lts_add_rdk_repo

Conversation

@niranjanyardi

Copy link
Copy Markdown
Member

git-subtree-dir: starboard/contrib/rdk
git-subtree-split: b9111ae7e92e74421697453c2966c3a637608a24
@niranjanyardi
niranjanyardi requested a review from kaidokert April 30, 2025 01:39
@niranjanyardi

niranjanyardi commented Apr 30, 2025 •

Copy link
Copy Markdown
Member Author

Should i add a DEPS file ? starboard/contrib/rdk/DEPS ?

There's a license file : starboard/contrib/rdk/LICENSE , do i need to add it to cobalt/content/licenses/platform/default/licenses_cobalt.txt ?

Should i add a METADATA file ? starboard/contrib/rdk/METADATA ?

Got all this from these instructions here: https://g3doc.corp.google.com/company/teams/cobalt/team/infrastructure/code_repository/add_new_repo.md?cl=head
Commands i ran: https://b.corp.google.com/issues/406054987#comment31

ptal @kaidokert

@niranjanyardi
niranjanyardi marked this pull request as ready for review April 30, 2025 01:49
@niranjanyardi
niranjanyardi requested review from jonastsai and oxve April 30, 2025 01:50

@kaidokert kaidokert left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonastsai

Copy link
Copy Markdown
Contributor

Do we consider to use git submodule to integrate RDK starboard? We can keep all the git logs when we change to submodule folder and run git log. Further more, we can change to newer version of RDK starboard by simply change the commit hash. And the RDK source code is downloaded only when we want to build it.

@jonastsai

Copy link
Copy Markdown
Contributor

A PR with git submodule is available at: #5629
FYI

@niranjanyardi
niranjanyardi merged commit 4e89c77 into youtube:25.lts.1+ May 1, 2025
@niranjanyardi

niranjanyardi commented May 1, 2025 •

Copy link
Copy Markdown
Member Author

Do we consider to use git submodule to integrate RDK starboard? We can keep all the git logs when we change to submodule folder and run git log. Further more, we can change to newer version of RDK starboard by simply change the commit hash. And the RDK source code is downloaded only when we want to build it.

@jonastsai we could consider this, but for all external repos until now we have followed git subtree procedure - so idk if it makes sense to make an exception for this repo. See #5621 (comment) for what instructions i followed. @oxve might have more ideas on why we chose git subtree instead of submodule

Edit: Thanks @oxve for providing the doc
here's the doc why we chose subtree: Unlike gclient DEPS or git submodules, git subtrees create copies of repositories without generating DEPS or .gitmodule metadata files. https://docs.google.com/document/d/1-I6GILtk2adC49QU6UwyWjpcsvZ5WFWf3gHitmCDfuM/edit?tab=t.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants