Skip to content

Improve starboard::shared::starboard::media::AvcParameterSets class to handle optional parameters - #5590

Merged
jasonzhangxx merged 1 commit into
youtube:mainfrom
iuriionishchenko:Improve_AvcParameterSets_to_add_optional_parameter_main_branch
May 27, 2025
Merged

Improve starboard::shared::starboard::media::AvcParameterSets class to handle optional parameters#5590
jasonzhangxx merged 1 commit into
youtube:mainfrom
iuriionishchenko:Improve_AvcParameterSets_to_add_optional_parameter_main_branch

Conversation

@iuriionishchenko

@iuriionishchenko iuriionishchenko commented Apr 28, 2025

Copy link
Copy Markdown
Collaborator

Improve starboard::shared::starboard::media::AvcParameterSets class to handle optional parameters

b/392649786

Change-Id: Ib00588c227ce5b638cbc563e47a329092c19104c

@iuriionishchenko iuriionishchenko mentioned this pull request Apr 28, 2025
Merged
@amurovanyi
amurovanyi self-requested a review April 28, 2025 21:52
@jasonzhangxx

jasonzhangxx commented Apr 28, 2025

Copy link
Copy Markdown
Contributor

Pre-commit check is failed. Please run pre-commit.

@iuriionishchenko

iuriionishchenko commented Apr 29, 2025

Copy link
Copy Markdown
Collaborator Author

Pre-commit check is failed. Please run pre-commit.

I tried but it looks like the pre-commit is broken in main branch. I got next messages
cobalt % git commit --amend
An error has occurred: InvalidConfigError:
==> File .pre-commit-config.yaml
==> At Config()
==> At key: default_stages
==> At index 0
=====> Expected one of commit, commit-msg, manual, merge-commit, post-checkout, post-commit, post-merge, post-rewrite, prepare-commit-msg, push but got: 'pre-commit'
Check the log at /Users/ionishchenko/.cache/pre-commit/pre-commit.log

@iuriionishchenko
iuriionishchenko force-pushed the Improve_AvcParameterSets_to_add_optional_parameter_main_branch branch from ba6df66 to 0456066 Compare April 29, 2025 11:40
@dahlstrom-g
dahlstrom-g requested review from a team as code owners April 30, 2025 18:43
@dahlstrom-g
dahlstrom-g requested a review from yell0wd0g April 30, 2025 18:43
@oxve

oxve commented May 1, 2025

Copy link
Copy Markdown
Member

@iuriionishchenko This PR was created with a broken commit from the main branch. The commit has been pruned from the main branch and in order to merge this you will also need to remove it.

Please follow the instructions below to fix your branch. Please ask us for assistance if you need any.

  1. Checkout your PR branch
  2. git fetch origin +main:main
  3. git rebase -i FETCH_HEAD
  4. Remove any commits that you didn’t add. Look for PR number in parantheses [e.g. ([Cobalt] Add catapult as git subtree #5457)] especially make sure "[Cobalt] Add catapult as git subtree ([Cobalt] Add catapult as git subtree #5457) is not included".
  5. git push fork +HEAD

@iuriionishchenko
iuriionishchenko force-pushed the Improve_AvcParameterSets_to_add_optional_parameter_main_branch branch from 0456066 to 95c78c0 Compare May 2, 2025 07:03
@amurovanyi

amurovanyi commented May 13, 2025

Copy link
Copy Markdown
Collaborator

@jasonzhangxx, please review this PR and merge, if approved

@andrewsavage1
andrewsavage1 removed the request for review from a team May 20, 2025 14:56
@iuriionishchenko
iuriionishchenko force-pushed the Improve_AvcParameterSets_to_add_optional_parameter_main_branch branch from 1b033f1 to d3d05a5 Compare May 21, 2025 10:40
jasonzhangxx
jasonzhangxx reviewed May 21, 2025
View reviewed changes
Comment thread starboard/shared/starboard/media/avc_util.h Resolved
@iuriionishchenko
Improve starboard::shared::starboard::media::AvcParameterSets class t…
be44d67 
…o handle optional parameters

b/392649786

Change-Id: Ib00588c227ce5b638cbc563e47a329092c19104c
@iuriionishchenko
iuriionishchenko force-pushed the Improve_AvcParameterSets_to_add_optional_parameter_main_branch branch from d3d05a5 to be44d67 Compare May 22, 2025 07:17
@jasonzhangxx
jasonzhangxx merged commit 0e162da into youtube:main May 27, 2025
kaidokert pushed a commit to kaidokert/cobalt that referenced this pull request Jun 15, 2025
@iuriionishchenko
Improve starboard::shared::starboard::media::AvcParameterSets class t…
d3be94c 
…o handle optional parameters (youtube#5590)

Improve starboard::shared::starboard::media::AvcParameterSets class to
handle optional parameters

b/392649786

Change-Id: Ib00588c227ce5b638cbc563e47a329092c19104c
briantting pushed a commit that referenced this pull request Jul 1, 2025
@iuriionishchenko
Improve starboard::shared::starboard::media::AvcParameterSets class t…
543e1ba 
…o handle optional parameters (#5590)

Improve starboard::shared::starboard::media::AvcParameterSets class to
handle optional parameters

b/392649786

Change-Id: Ib00588c227ce5b638cbc563e47a329092c19104c
original-hexsha: 0e162da
briantting pushed a commit that referenced this pull request Jul 11, 2025
@iuriionishchenko @briantting
Improve starboard::shared::starboard::media::AvcParameterSets class t…
388e1cd 
…o handle optional parameters (#5590)

Improve starboard::shared::starboard::media::AvcParameterSets class to
handle optional parameters

b/392649786

Change-Id: Ib00588c227ce5b638cbc563e47a329092c19104c
original-hexsha: 0e162da
sideb0ard pushed a commit to sideb0ard/cobalt that referenced this pull request Jul 25, 2025
@iuriionishchenko
[CONFLICT] Original Commit: 8ff4b76cb0a1a04bc0c181c2d5248ce6334f2861
f1c9326 
Original Message:
Improve starboard::shared::starboard::media::AvcParameterSets class to handle optional parameters (youtube#5590)

Improve starboard::shared::starboard::media::AvcParameterSets class to
handle optional parameters

b/392649786

Change-Id: Ib00588c227ce5b638cbc563e47a329092c19104c
original-hexsha: 0e162da


Files with conflicts:
- starboard/shared/starboard/media/avc_util.cc
- starboard/shared/starboard/media/avc_util.h
sideb0ard pushed a commit to sideb0ard/cobalt that referenced this pull request Jul 26, 2025
@iuriionishchenko @sideb0ard
Improve starboard::shared::starboard::media::AvcParameterSets class t…
255e533 
…o handle optional parameters (youtube#5590)

Improve starboard::shared::starboard::media::AvcParameterSets class to
handle optional parameters

b/392649786

Change-Id: Ib00588c227ce5b638cbc563e47a329092c19104c
original-hexsha: 0e162da
sideb0ard pushed a commit to sideb0ard/cobalt that referenced this pull request Jul 30, 2025
@iuriionishchenko @sideb0ard
Improve starboard::shared::starboard::media::AvcParameterSets class t…
3d28358 
…o handle optional parameters (youtube#5590)

Improve starboard::shared::starboard::media::AvcParameterSets class to
handle optional parameters

b/392649786

Change-Id: Ib00588c227ce5b638cbc563e47a329092c19104c
original-hexsha: 0e162da
briantting pushed a commit that referenced this pull request Aug 15, 2025
@iuriionishchenko
Improve starboard::shared::starboard::media::AvcParameterSets class t…
6c63134 
…o handle optional parameters (#5590)

Improve starboard::shared::starboard::media::AvcParameterSets class to
handle optional parameters

b/392649786

Change-Id: Ib00588c227ce5b638cbc563e47a329092c19104c

original-hexsha: 0e162da
sideb0ard pushed a commit that referenced this pull request Aug 20, 2025
@iuriionishchenko @sideb0ard
Improve starboard::shared::starboard::media::AvcParameterSets class t…
4495c45 
…o handle optional parameters (#5590)

Improve starboard::shared::starboard::media::AvcParameterSets class to
handle optional parameters

b/392649786

Change-Id: Ib00588c227ce5b638cbc563e47a329092c19104c

original-hexsha: 0e162da
briantting pushed a commit that referenced this pull request Aug 29, 2025
@iuriionishchenko @briantting
Improve starboard::shared::starboard::media::AvcParameterSets class t…
d8c32b2 
…o handle optional parameters (#5590)

Improve starboard::shared::starboard::media::AvcParameterSets class to
handle optional parameters

b/392649786

Change-Id: Ib00588c227ce5b638cbc563e47a329092c19104c

original-hexsha: 0e162da
madhurajayaraman pushed a commit to madhurajayaraman/cobalt that referenced this pull request Sep 9, 2025
@iuriionishchenko @madhurajayaraman
Improve starboard::shared::starboard::media::AvcParameterSets class t…
5604a8a 
…o handle optional parameters (youtube#5590)

Improve starboard::shared::starboard::media::AvcParameterSets class to
handle optional parameters

b/392649786

Change-Id: Ib00588c227ce5b638cbc563e47a329092c19104c

original-hexsha: 0e162da
sideb0ard pushed a commit to sideb0ard/cobalt that referenced this pull request Sep 10, 2025
@iuriionishchenko @sideb0ard
Improve starboard::shared::starboard::media::AvcParameterSets class t…
3f990eb 
…o handle optional parameters (youtube#5590)

Improve starboard::shared::starboard::media::AvcParameterSets class to
handle optional parameters

b/392649786

Change-Id: Ib00588c227ce5b638cbc563e47a329092c19104c

original-hexsha: 0e162da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonzhangxx jasonzhangxx jasonzhangxx approved these changes
@yell0wd0g yell0wd0g Awaiting requested review from yell0wd0g yell0wd0g was automatically assigned from youtube/cobalt-3p-repository-owners
+1 more reviewer
@amurovanyi amurovanyi amurovanyi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iuriionishchenko @jasonzhangxx @oxve @amurovanyi