Repository navigation
Fwd port fix for build ids containing a zero byte - #5502
Merged
Merged
Conversation
yell0wd0g
reviewed
Apr 22, 2025
yell0wd0g
left a comment
yell0wd0g
left a comment
Contributor
There was a problem hiding this comment.
We're starting to scratch the surface :)
yell0wd0g
approved these changes
Apr 23, 2025
yell0wd0g
left a comment
yell0wd0g
left a comment
Contributor
There was a problem hiding this comment.
LGTM as-is for the fix with comments addressed.
This change is based on youtube#5480, which makes this fix on the 25.lts.1+ branch. This current change goes a step further by changing the type of build_id in the EvergreenInfo struct; a uint8_t array should better represent the data and provide some type safety. b/408471930
hlwarriner
enabled auto-merge (squash)
April 23, 2025 22:24
kaidokert
pushed a commit
to kaidokert/cobalt
that referenced
this pull request
Jun 15, 2025
This change is based on youtube#5480, which makes this fix on the 25.lts.1+ branch. This current change goes a step further by changing the type of build_id in the EvergreenInfo struct; a uint8_t array should better represent the data and provide some type safety. b/408471930
sideb0ard
pushed a commit
to sideb0ard/cobalt
that referenced
this pull request
Jul 25, 2025
Original Message: Fwd port fix for build ids containing a zero byte (youtube#5502) This change is based on youtube#5480, which makes this fix on the 25.lts.1+ branch. This current change goes a step further by changing the type of build_id in the EvergreenInfo struct; a uint8_t array should better represent the data and provide some type safety. b/408471930 original-hexsha: cb7ef3a Files with conflicts: - starboard/elf_loader/evergreen_info.h
sideb0ard
pushed a commit
to sideb0ard/cobalt
that referenced
this pull request
Jul 26, 2025
This change is based on youtube#5480, which makes this fix on the 25.lts.1+ branch. This current change goes a step further by changing the type of build_id in the EvergreenInfo struct; a uint8_t array should better represent the data and provide some type safety. b/408471930 original-hexsha: cb7ef3a
sideb0ard
pushed a commit
to sideb0ard/cobalt
that referenced
this pull request
Jul 30, 2025
This change is based on youtube#5480, which makes this fix on the 25.lts.1+ branch. This current change goes a step further by changing the type of build_id in the EvergreenInfo struct; a uint8_t array should better represent the data and provide some type safety. b/408471930 original-hexsha: cb7ef3a
madhurajayaraman
pushed a commit
to madhurajayaraman/cobalt
that referenced
this pull request
Sep 9, 2025
This change is based on youtube#5480, which makes this fix on the 25.lts.1+ branch. This current change goes a step further by changing the type of build_id in the EvergreenInfo struct; a uint8_t array should better represent the data and provide some type safety. b/408471930 original-hexsha: cb7ef3a
sideb0ard
pushed a commit
to sideb0ard/cobalt
that referenced
this pull request
Sep 10, 2025
This change is based on youtube#5480, which makes this fix on the 25.lts.1+ branch. This current change goes a step further by changing the type of build_id in the EvergreenInfo struct; a uint8_t array should better represent the data and provide some type safety. b/408471930 original-hexsha: cb7ef3a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is based on #5480, which makes this fix on the 25.lts.1+ branch. This current change goes a step further by changing the type of build_id in the EvergreenInfo struct; a uint8_t array should better represent the data and provide some type safety.
b/408471930