Repository navigation
Cherry pick PR #5127: starboard: roll up the remaining unittest targets - #5413
Merged
Merged
Conversation
This PR continues the work of #4831 and rolls up all other targets I could find that looked like unit tests into `starboard_unittests`. With this I see ``` [==========] 1454 tests from 55 test suites ran. (8612 ms total) [ PASSED ] 989 tests. [ SKIPPED ] 465 tests, listed below: ... YOU HAVE 1 DISABLED TEST ``` (the disabled test was from before, the skipped ones are new, see further below). Media-related topics: - A number of tetst (e.g. `AudioDecoderTest` and others) needed a number of system libraries to support codecs like AAC, AC3 etc but those are part of non-free Debian repos, so couldn't install those in Docker. This CL adds a new method `IsProprietaryAudioCodec()` to be used to SKIP test cases related to those codecs, when the build flag `SKIP_PROPRIETARY_CODEC_TESTS` is present. - `VideoDecoderTests` and `PlayerComponentsTest` failed flakily due to X11 use not being torn down correctly; they need `xvfb-run`. This makes me think those are not pure unit-tests but integration tests like `nplb`. For the time being they are commented out with a TODO. - `media_util_test.cc` needed `operator==` on `SbMediaColorMetadata`s, so I added it as extern. - `FileCacheReader` needs to find the media files under the output folder's `content/` directory. Files are under the output folder's `starboard/content`, because of the starboard toolchain. This CL leaves a quick hack and a TODO() to find a proper solution. Finally: - `//starboard/raspi/shared/:starboard_platform_tests` target was empty, this CL removes it. Bug: b/384819454 (cherry picked from commit 82430e3)
Collaborator
Author
|
Important There were merge conflicts while cherry picking! Check out cherry-pick-26.android-5127 and fix the conflicts before proceeding. Check the log at https://github.com/youtube/cobalt/actions/runs/14458194812 for details. |
Contributor
|
Needs #5393 first |
yell0wd0g
approved these changes
Apr 15, 2025
Datadog ReportBranch report: ✅ 0 Failed, 37388 Passed, 3390 Skipped, 1m 24.16s Total Time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #5127
This PR continues the work of #4831 and rolls up all other targets I could find that looked like unit tests into
starboard_unittests.With this I see
(the disabled test was from before, the skipped ones are new, see further below).
Media-related topics:
AudioDecoderTestand others) needed a number of system libraries to support codecs like AAC, AC3 etc but those are part of non-free Debian repos, so couldn't install those in Docker. This CL adds a new methodIsProprietaryAudioCodec()to be used to SKIP test cases related to those codecs, when the build flagSKIP_PROPRIETARY_CODEC_TESTSis present.VideoDecoderTestsandPlayerComponentsTestfailed flakily due to X11 use not being torn down correctly; they needxvfb-run. This makes me think those are not pure unit-tests but integration tests likenplb. For the time being they are commented out with a TODO.media_util_test.ccneededoperator==onSbMediaColorMetadatas, so I added it as extern.FileCacheReaderneeds to find the media files under the output folder'scontent/directory. Files are under the output folder'sstarboard/content, because of the starboard toolchain. This CL leaves a quick hack and a TODO() to find a proper solution.Finally:
//starboard/raspi/shared/:starboard_platform_teststarget was empty, this CL removes it.Bug: b/384819454